Skip to content

Fix the incorrect comment for set_blocking() #8580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

tz-arm
Copy link
Contributor

@tz-arm tz-arm commented Oct 30, 2018

Description

Fix the incorrect comment for set_blocking() which impact the online API document.
Before:
* set_blocking(false) is equivalent to set_timeout(-1)
* set_blocking(true) is equivalent to set_timeout(0)
After:
* set_blocking(false) is equivalent to set_timeout(0)
* set_blocking(true) is equivalent to set_timeout(-1)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team October 30, 2018 08:54
@cmonr
Copy link
Contributor

cmonr commented Oct 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

Build : SUCCESS

Build number : 3509
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8580/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants