-
Notifications
You must be signed in to change notification settings - Fork 3k
NRF52 : Fix UART RTS initialization #8474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The first 'this'. Do you mean the enum preprocessor issue? |
@cmonr Sorry for the cryptic message. I changed it to "The above PR does not work for NRF52840_DK and needs this fix." |
LGTM (cant approve as github is having issues), will start CI /morph build |
1 similar comment
LGTM (cant approve as github is having issues), will start CI /morph build |
Build : FAILUREBuild number : 3424 |
Build : FAILUREBuild number : 3425 |
b7b69da
to
1d4ef69
Compare
@naveenkaje Was this a rebase, or were the failure issues fixed and squashed? Hard to tell. |
1d4ef69
to
ba132fe
Compare
@cmonr I had originally changed only targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/reloc_vector_table.c, but during CI I noted that the following files needed the RTS pin definition targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/TARGET_DELTA_DFBM_NQ620/PinNames.h Hence I modified them and rebased on top of master. |
/morph build |
Build : FAILUREBuild number : 3430 |
Interesting. Looks like the last build issue is only with the DELTA_DFBM_NQ620 target. |
Thanks @cmonr It is caused due to multiply defined mbed_sdk_init() for that target.
Looking at the history, 56cf092 has brought this call for that target. The function is not doing anything particularly useful. It is declaring a couple of local variables. I propose to delete this file. |
The preprocessor based macro check #if evaluates all enums as 0 and hence the code does not get compiled. Since move this to a runtime check where the pin variable can be correctly evaluated. Delete mbed_overrides.c as it has a target specific mbed_sdk_init() to resolve linking problem. This is a follow on patch to: ARMmbed#8046
ba132fe
to
7beb8d3
Compare
/morph build |
Build : SUCCESSBuild number : 3446 Triggering tests/morph test |
Test : FAILUREBuild number : 3233 |
Exporter Build : SUCCESSBuild number : 3066 |
Job config fixed. |
1 similar comment
Job config fixed. |
Test : SUCCESSBuild number : 3236 |
Waiting on new greentea tests. Should be about an hour until complete. |
This change was based on original version of ARMmbed#8474. After the reviews, the it changed from pre-processor based check to code based check. Do the same here in this branch
The pre-processor based macro check #if evaluates all enums as
0 and hence the code within #if does not get compiled. Hence
move this to a run-time check where the pin variable can be
correctly evaluated.
This is a follow on patch to:
#8046
The above PR does not work for NRF52840_DK and needs this fix.