-
Notifications
You must be signed in to change notification settings - Fork 3k
Block device general tests #8430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block device general tests #8430
Conversation
It does not look like a target update but rather docs update and also adding tests |
1. [Hardware requirements](#hardware-requirements) | ||
2. [Usage](#usage) | ||
- [Compile the test](#compile-the-test) | ||
- [Run the test](#run-the-test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link doesnt work (I think text and link should be "run the example")
|
||
## Changing the block device | ||
|
||
In Mbed OS, a C++ classes that inherits from the [BlockDevice](https://os.mbed.com/docs/latest/reference/storage.html#block-devices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: class instead of classes
@AnotherButler Please review the readme file |
@theamirocohen Curious. What was the reason for removing the PR type from the description? |
/morph build |
Build : FAILUREBuild number : 3413 |
@theamirocohen there are some build errors in the build, please take a look |
@theamirocohen It looks like this also needs to be rebased. Will manually restart the CI pipeline once the PR is updated, assuming GitHub is still experiencing issues. |
Copy edit file, mostly for active voice.
e587d27
to
7962e0c
Compare
seems to be rebased now. |
Build : SUCCESSBuild number : 3437 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3058 |
failure seems unrelated. rechecking |
Test : FAILUREBuild number : 3226 |
Exporter Build : SUCCESSBuild number : 3059 |
/morph build |
@theamirocohen Any more commits you'd like to add to the PR? |
Oh, I need to put a sock in my mouth. Didn't notice that commit fixed something... |
Build : SUCCESSBuild number : 3442 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3063 |
Test : SUCCESSBuild number : 3230 |
Suite of tests that can be easily configured to use a custom block device