Skip to content

Block device general tests #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 23, 2018

Conversation

theamirocohen
Copy link
Contributor

@theamirocohen theamirocohen commented Oct 15, 2018

Suite of tests that can be easily configured to use a custom block device

@theamirocohen
Copy link
Contributor Author

@yossi2le @offirko
I'll be happy for your review

@0xc0170 0xc0170 requested a review from a team October 15, 2018 22:31
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2018

[x] Target update

It does not look like a target update but rather docs update and also adding tests

1. [Hardware requirements](#hardware-requirements)
2. [Usage](#usage)
- [Compile the test](#compile-the-test)
- [Run the test](#run-the-test)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link doesnt work (I think text and link should be "run the example")


## Changing the block device

In Mbed OS, a C++ classes that inherits from the [BlockDevice](https://os.mbed.com/docs/latest/reference/storage.html#block-devices)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: class instead of classes

@0xc0170 0xc0170 requested a review from AnotherButler October 17, 2018 23:40
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 17, 2018

@AnotherButler Please review the readme file

@cmonr
Copy link
Contributor

cmonr commented Oct 19, 2018

@theamirocohen Curious. What was the reason for removing the PR type from the description?

@cmonr
Copy link
Contributor

cmonr commented Oct 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

Build : FAILURE

Build number : 3413
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8430/

@NirSonnenschein
Copy link
Contributor

@theamirocohen there are some build errors in the build, please take a look

@cmonr
Copy link
Contributor

cmonr commented Oct 22, 2018

@theamirocohen It looks like this also needs to be rebased.

Will manually restart the CI pipeline once the PR is updated, assuming GitHub is still experiencing issues.

@NirSonnenschein
Copy link
Contributor

seems to be rebased now.
/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3437
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8430/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@NirSonnenschein
Copy link
Contributor

failure seems unrelated. rechecking
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@NirSonnenschein
Copy link
Contributor

/morph build

@cmonr
Copy link
Contributor

cmonr commented Oct 23, 2018

@theamirocohen Any more commits you'd like to add to the PR?

@cmonr
Copy link
Contributor

cmonr commented Oct 23, 2018

Oh, I need to put a sock in my mouth. Didn't notice that commit fixed something...

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3442
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8430/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

@cmonr cmonr merged commit 2a50409 into ARMmbed:master Oct 23, 2018
@cmonr cmonr removed the needs: CI label Oct 23, 2018
@theamirocohen theamirocohen deleted the block_device_general_tests branch October 29, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants