Revert "Merge pull request #8183 from hasnainvirk/QOS_impl"

[cmonr]

Description

It was observed that after gatekeeping today, new PRs started failing. PR #8183 caused one of the tests to start failing, thus breaking master.

The following events led to this revert being needed:

• Adding QOS in response to LinkADRReq and fixing class C bugs #8183 was opened.
• Unit tests were automatically run on the PR and passed.
• Due to high PR and CI load, maintainers were not able to start testing the PR until a few days ago.
  • PR remained opened for over 20 days.
• Once PR received maintainer attention, the PR passed typical maintainer-kicked CI jobs.
• Unittests remained green, and all other tests indicated green. PR was merged today.

At some point in between when unittests were automatically run on the PR, and when it was merged, either master had moved to a point, or the test job had been updated such that the PR was now breaking unittests.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

[cmonr]

@hasnainvirk Asking for your ok to bring this in, since it undoes your changes. After this, opening a new PR with the contents of #8183 would show the errors that are now present in master.

The command to test them: python ./UNITTESTS/mbed_unittest.py --compile --coverage both --clean

[0xc0170]

Making master green 👍

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 3330
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8393/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2962
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8393/

[mbed-ci]

Test : SUCCESS

Build number : 3138
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8393/3138

[SeppoTakalo]

Revert instead of fixing the unittest? Have you tried to contact Hasnain or Antti?

[adbridge]

@SeppoTakalo Yeah Hasnain is tagged above, the problem is we need this sorted asap as all other PRs are blocked until it is. Quickest fix as Cruz said is to revert it and then one of the guys can fix it in their own time.