Skip to content

Mts dragonfly l471 qg #8382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

Mts dragonfly l471 qg #8382

wants to merge 25 commits into from

Conversation

AnttiKauppila
Copy link

Description

Fixed #7304 to fit to mbed-os-5.10 branch
Multitech will need to have it in 5.10.2 patch release latest.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

cedrickkukela-cd and others added 24 commits October 11, 2018 18:46
@cedrickkukela-cd
adding TARGET MTS_DRAGONFLY_L471QG
1356126
@cedrickkukela-cd
Ublox and PinName fixes
cc1c296
@cedrickkukela-cd
target fix
8aeb0c4
@cedrickkukela-cd
fixing onboard modem init bug on mts dragonfly l471
b12b08b
@cedrickkukela-cd
change startup and s file names to match target
5a4a2a0
@cedrickkukela-cd
delete file
20943c0
@cedrickkukela-cd
remove blanks
aa49765
@cedrickkukela-cd
changes to support mts dragonfly nano ppp
86e1a27
@cedrickkukela-cd
Rev c pin name fix
cc3fd08
@cedrickkukela-cd
REV D change for modem on
f617619
@cedrickkukela-cd
target changes
8a09249
@felser
Fix rev D radio init/power/reset and add back bootloader capability
eed8a52
@felser
Fixed spacing/tabs and clean up targets.json
f4daabb
@felser
Remove commented out code
52815c2
@felser
Rebased on master mbed-os 9/7/18
cbdfec5 
This required replacing hal_tick.h with us_ticker_data.h
@felser
Rebase and changes for Dragonfly nano support
24b7687
@felser
Decrease heap size in IAR linker so tests compile and use SRAM2 for I…
96ffa34 
…AR and GCC
@felser
Fix so building for other targets does not fail
baab349
@felser
Remove LOWPOWERTIMER as it has been replaced by LPTICKER
d819f02
@felser
Fix rebase conflict file
f9a68b9
@felser
Fix broken cellular_device test and delete commented code
a78e6ea
@felser
Add header so cellular_power tests compile and run
e56df4a
@felser
Delete commented out merge conflict resolution
fb1aec3
@felser
Configure IAR stack size to 1KB
6c600f5
@cmonr cmonr requested a review from maclobdell October 11, 2018 15:58
@cmonr
Copy link
Contributor

cmonr commented Oct 11, 2018

The DNM label is for us. This will be cherry picked once it's passed CI and 5.10.2 is being generated.

@cmonr cmonr requested a review from a team October 11, 2018 16:00
@cmonr
Copy link
Contributor

cmonr commented Oct 11, 2018

@cedrickkukela-cd Wasn't able to add you as a reviewer, but please take a look as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2018

the only change here compare to master is 33a315d (this resolves the conflict) ?

felser
felser approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@felser felser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

maclobdell
maclobdell approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@maclobdell maclobdell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve just to make sure I don't block this further. I will run the tests asap, but my test setup (sim and/or network coverage) has been known not to work well. I have sent additional units to Oulu to test. Please go ahead and merge. We will confirm all test results as soon as possible before providing official Mbed Enabled approval.

@AnttiKauppila
Copy link
Author

@felser you are right. I modified the code to work correctly

@cmonr
Copy link
Contributor

cmonr commented Oct 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3338
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8382/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

Exporter Build : FAILURE

Build number : 2971
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8382/

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

Test : SUCCESS

Build number : 3146
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8382/3146

@NirSonnenschein
Copy link
Contributor

looks like iar license related issue - rerunning

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2018

Exporter Build : SUCCESS

Build number : 2985
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8382/

@NirSonnenschein
Copy link
Contributor

@cmonr this passed CI, is the "do not merge" flag still relevant?

@cmonr
Copy link
Contributor

cmonr commented Oct 15, 2018

@NirSonnenschein Yes, because this will be cherry picked into the release branch as a part of generating the next patch release instead of being directly merged.

@cmonr
Copy link
Contributor

cmonr commented Oct 22, 2018

Closing since this has been successfully cherry-picked into 5.10.2.

@cmonr cmonr closed this Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclobdell maclobdell maclobdell approved these changes

@felser felser felser approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@AnttiKauppila @cmonr @0xc0170 @mbed-ci @NirSonnenschein @maclobdell @felser @adbridge @cedrickkukela-cd