Skip to content

Add K66F default sd storage #8348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2018
Merged

Add K66F default sd storage #8348

merged 2 commits into from
Oct 22, 2018

Conversation

maclobdell
Copy link
Contributor

Description

K66F has an SD Card. Let's implement it as the default storage using the new default storage mechanism in 5.10. This helps ensure new example apps that use BlockDevice::get_default_instance(); work with no extra configuring.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

@mmahadevan108
Copy link
Contributor

Will this be using the SD card available via the Arduino connector (e.g ci-test shield)?

@maclobdell
Copy link
Contributor Author

@mmahadevan108 the K66F has an on-board micro SD card connector. so arduino shield is not necessary.

@geky geky requested review from dannybenor, yossi2le and a team October 11, 2018 03:44
yossi2le
yossi2le reviewed Oct 11, 2018
View reviewed changes
@maclobdell
Copy link
Contributor Author

I updated the branch to remove the Feature: Storage, so the CFStore will not be added with this PR.

yossi2le
yossi2le approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

Build : SUCCESS

Build number : 3418
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8348/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

Exporter Build : SUCCESS

Build number : 3042
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8348/

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

Test : SUCCESS

Build number : 3212
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8348/3212

@cmonr cmonr merged commit 353e8bd into ARMmbed:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@cmonr cmonr cmonr approved these changes

@yossi2le yossi2le yossi2le approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dannybenor dannybenor Awaiting requested review from dannybenor

Assignees
No one assigned
Labels
release-version: 5.10.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maclobdell @mmahadevan108 @NirSonnenschein @mbed-ci @cmonr @0xc0170 @yossi2le