Add support for RapidIoT #8307

mmahadevan108 · 2018-10-02T20:23:17Z

Description

This PR requires

Update to greentea set forced_reset_timeout 10 sec for RAPIDIOT_K64F greentea#282
Update to mbed-ls Add support for RapidIoT mbed-ls#393
Update to DAPLink RapidIoT: Need separate board ID for the K64F and KW41Z DAPLink#508

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

mmahadevan108 · 2018-10-02T20:23:56Z

cc @maclobdell @cmonr @0xc0170

0xc0170 · 2018-10-05T12:49:47Z

Update to greentea ARMmbed/greentea#282
Update to mbed-ls ARMmbed/mbed-ls#393
Update to DAPLink ARMmbed/DAPLink#508

needs: preceding PR

cmonr · 2018-10-08T18:43:38Z

Interesting.

@ARMmbed/mbed-os-test
This should only require PR updates, correct? No changes/updatess to CI needed?

studavekar · 2018-10-08T18:58:26Z

@cmonr as the board is not part of HW test, no need to update tools.

0xc0170 · 2018-10-09T16:54:09Z

@maclobdell @ashok-rao Please review

ashok-rao · 2018-10-10T18:26:57Z

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_RAPIDIOT/PinNames.h

+
+    I2C_SCL = PTC10,
+    I2C_SDA = PTC11,
+


@mmahadevan108 : No SPI brought out?

I have added SPI defines in the PinNames.h file.

ashok-rao · 2018-10-10T18:30:32Z

targets/targets.json

+        "macros": ["FSL_RTOS_MBED", "USE_EXTERNAL_RTC"],
+        "default_toolchain": "ARM",
+        "default_lib": "std",
+        "release_versions": ["2", "5"]


@mmahadevan108 : you may want to add a "public: false" here for the parent target..

Thank you. I have made this change and updated the PR.

ashok-rao · 2018-10-10T18:34:22Z

targets/targets.json

+        "macros_add": ["CPU_MK64FN1M0VMD12", "TARGET_K64F"],
+        "is_disk_virtual": true,
+        "mbed_rom_start": "0x00014000",
+        "mbed_rom_size": "0xEC000",


@0xc0170, @mmahadevan108 / @maclobdell : Would it be better to move these 2 (ram,rom starts) to the respective linker descriptions (ARMCC / GCC / IAR) rather than here? wrapped in an #ifdef for the rapidiot targets only..

https://github.com/ARMmbed/mbed-os/blob/master/tools/config/__init__.py#L628 - cant find the documentation so the code reference.

ashok-rao

Thanks @mmahadevan108 . Some minor comments added. Otherwise looking good!

0xc0170 · 2018-10-11T17:43:20Z

@mmahadevan108 Can you review latest comments? This addition is almost ready for CI

Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 · 2018-10-16T14:03:12Z

@ashok-rao @0xc0170 I have updated the PR with changes to include comments received.

cmonr · 2018-10-16T16:28:40Z

@ashok-rao @maclobdell Could y'all take another look? Ignore the unittest result, as it's not this PR's fault.

ashok-rao · 2018-10-17T11:21:40Z

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_RAPIDIOT/PinNames.h

+    SPI_MOSI    = PTC6,
+    SPI_MISO    = PTC7,
+    SPI_SCK     = PTC5,
+    SPI_PERSISTENT_MEM_CS = PTC4,


@mmahadevan108 : Not sure if this pin name for the CS maintains consistency with others? why not SPI_SSEL or SPI_NCS ..?
cc @0xc0170 @cmonr ..

I am not familiar with the names, I copied this from K64F. These are new additions and I am not familiar with the use-case for which these were added, please suggest and I will make the change.

@yossi2le Can you review this one?

ashok-rao

Just a minor comment added on naming convention.. rest all LGTM! Thanks @mmahadevan108 ..

cmonr · 2018-10-17T17:26:32Z

/morph build

mbed-ci · 2018-10-17T20:18:20Z

Build : SUCCESS

Build number : 3392
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8307/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-17T21:29:46Z

Exporter Build : SUCCESS

Build number : 3023
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8307/

mbed-ci · 2018-10-18T04:03:53Z

Test : SUCCESS

Build number : 3193
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8307/3193

mmahadevan108 force-pushed the Add-Support_RapidIoT branch 2 times, most recently from 0b2cc58 to 6e86296 Compare October 3, 2018 17:03

0xc0170 added the needs: review label Oct 4, 2018

0xc0170 requested review from maclobdell and ashok-rao October 4, 2018 10:19

0xc0170 added the scope: new-target label Oct 4, 2018

0xc0170 requested a review from a team October 4, 2018 15:37

0xc0170 approved these changes Oct 5, 2018

View reviewed changes

0xc0170 added the needs: preceding PR label Oct 5, 2018

0xc0170 removed the needs: preceding PR label Oct 9, 2018

ashok-rao reviewed Oct 10, 2018

View reviewed changes

adbridge added needs: work priority: high and removed needs: review labels Oct 12, 2018

maclobdell and others added 2 commits October 16, 2018 08:52

Add support for NXP Rapid IoT prototyping kit

fd08cc9

Signed-off-by: Mahesh Mahadevan <[email protected]>

MCUXpresso Flash Driver: Update Flash driver to support RAPIDIOT

9a47915

Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 force-pushed the Add-Support_RapidIoT branch from 6e86296 to 9a47915 Compare October 16, 2018 14:01

cmonr added needs: review and removed needs: work labels Oct 16, 2018

ashok-rao reviewed Oct 17, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 17, 2018

cmonr added the release-version: 5.10.2 label Oct 18, 2018

cmonr merged commit c9adf3c into ARMmbed:master Oct 18, 2018

cmonr removed the needs: CI label Oct 18, 2018

mmahadevan108 deleted the Add-Support_RapidIoT branch October 18, 2018 13:59

Add support for RapidIoT #8307

Add support for RapidIoT #8307

Uh oh!

Conversation

mmahadevan108 commented Oct 2, 2018

Description

Pull request type

Uh oh!

mmahadevan108 commented Oct 2, 2018

Uh oh!

0xc0170 commented Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Oct 8, 2018

Uh oh!

studavekar commented Oct 8, 2018

Uh oh!

0xc0170 commented Oct 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 11, 2018

Uh oh!

mmahadevan108 commented Oct 16, 2018

Uh oh!

cmonr commented Oct 16, 2018

Uh oh!

ashok-rao Oct 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Oct 17, 2018

Uh oh!

mbed-ci commented Oct 17, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 17, 2018

Uh oh!

mbed-ci commented Oct 18, 2018

Uh oh!

Uh oh!

0xc0170 commented Oct 5, 2018 •

edited

Loading

ashok-rao Oct 17, 2018 •

edited

Loading