Skip to content

storage: fix component coding style #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 25, 2018

Description

Components astyle update

The only exception I made was inlined assembly in rf driver (skipped from astyle).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested review from SeppoTakalo and a team September 25, 2018 13:36
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 25, 2018

Are these components still maintained outside this repository (should this be addressed there first) ?

@yossi2le
Copy link
Contributor

yossi2le commented Sep 25, 2018

Are these components still maintained outside this repository (should this be addressed there first)?

I can only answer about the storage components. I believe that besides bug fixes affecting 5.9 or earlier versions, no new functionality will be added to the external repo. So I think it's not a must to Astyle the external repos.

@SeppoTakalo
Copy link
Contributor

RF and WiFi drivers are still developed outside of Mbed OS tree for faster review&test cycle.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 25, 2018

RF and WiFi drivers are still developed outside of Mbed OS tree for faster review&test cycle.

How can we move this there so they match ? I can send PR to those (same astyle command run), would that help?

Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like great Astyling for me:)
10x.

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

@0xc0170 Needs work?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 23, 2018

I am on it within a day. If not, I'll close this PR and reopen once I sync all repos with the styling changes.

@0xc0170 0xc0170 force-pushed the fix_components_astyle branch from 17c4766 to 53f1397 Compare October 25, 2018 08:52
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 25, 2018

I scoped down this to storage component only. Same commit, so latest review should stand and this should be ready for CI

@SeppoTakalo As wifi and rc components are outside of this tree, can anyone from your team do style clean-up in the repos and send an update to Mbed OS?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 25, 2018

/morph build

@0xc0170 0xc0170 changed the title Fix components astyle storage: fix component coding style Oct 25, 2018
@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

Build : SUCCESS

Build number : 3459
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8244/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 25, 2018

@ARMmbed/mbed-os-maintainers your review needed here

@cmonr cmonr merged commit 395ea06 into ARMmbed:master Oct 25, 2018
@cmonr cmonr removed the needs: CI label Oct 25, 2018
@0xc0170 0xc0170 deleted the fix_components_astyle branch October 26, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants