-
Notifications
You must be signed in to change notification settings - Fork 3k
storage: fix component coding style #8244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are these components still maintained outside this repository (should this be addressed there first) ? |
I can only answer about the storage components. I believe that besides bug fixes affecting 5.9 or earlier versions, no new functionality will be added to the external repo. So I think it's not a must to Astyle the external repos. |
RF and WiFi drivers are still developed outside of Mbed OS tree for faster review&test cycle. |
How can we move this there so they match ? I can send PR to those (same astyle command run), would that help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like great Astyling for me:)
10x.
@0xc0170 Needs work? |
I am on it within a day. If not, I'll close this PR and reopen once I sync all repos with the styling changes. |
17c4766
to
53f1397
Compare
I scoped down this to storage component only. Same commit, so latest review should stand and this should be ready for CI @SeppoTakalo As wifi and rc components are outside of this tree, can anyone from your team do style clean-up in the repos and send an update to Mbed OS? |
/morph build |
Build : SUCCESSBuild number : 3459 Triggering tests/morph test |
Test : SUCCESSBuild number : 3250 |
Exporter Build : SUCCESSBuild number : 3081 |
@ARMmbed/mbed-os-maintainers your review needed here |
Description
Components astyle update
The only exception I made was inlined assembly in rf driver (skipped from astyle).
Pull request type