Fix for issue #8155 (NRF52832: time stops after 35 minutes) #8165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Low power Timer is used as RTC for platforms that don't have HW RTC capabilities (like NRF52832). `_rtc_lpticker_read(void)` function currently uses `Timer::read()` function to trace elapsed time. `Timer::read()` returns seconds represented as `float` value, but this value is calculated from `int` since `Timer::read_us()` returns `int`. This limits time tracing to ~35 min. To fix this problem we will use `timer::read_high_resolution_us()` (which returns unsigned 64 bit value) instead of `Timer::read()`.
0xc0170
approved these changes
Sep 18, 2018
|
Yup, that's the fix, my test code now sees no return to zero at the 35 minute (~2150 seconds) mark: |
RobMeades
approved these changes
Sep 18, 2018
c1728p9
approved these changes
Sep 18, 2018
|
Super - this also fixes #7836. My PR for that was not good and I haven't returned to it yet. |
|
/morph build |
Build : SUCCESSBuild number : 3143 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2750 |
Test : SUCCESSBuild number : 2947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Low power Timer is used as RTC for platforms that don't have HW RTC capabilities (like NRF52832).
_rtc_lpticker_read(void)function currently usesTimer::read()function to trace elapsed seconds.Timer::read()returns seconds represented asfloatvalue, but this value is calculated fromintsinceTimer::read_us()returnsint.This limits time tracing to ~35 min.
To fix this problem we will use
timer::read_high_resolution_us()(which returns unsigned 64 bit value) instead ofTimer::read().Pull request type