Skip to content

Add usticker feature to TMPM066 #8149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Oct 8, 2018
Merged

Add usticker feature to TMPM066 #8149

merged 2 commits into from Oct 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2018

Description

Add usticker feature to TMPM066

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change

0xc0170
0xc0170 requested changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with all 3 toolchains ? How this is fixing us ticker - it was disabled - so reenabling with reworking the us ticker to use different peripheral ticker ?

targets/TARGET_TOSHIBA/TARGET_TMPM066/us_ticker.c
}

void us_ticker_clear_interrupt(void)
{
//no flags to clear
INTIFSD_ClearINTReq(INTIFSD_INT_SRC_TMRB_7_MDOVF);
NVIC_ClearPendingIRQ(INTTB7_IRQn);
}

void us_ticker_free(void)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this function still be empty?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used only function body for compilation success. However implemented the function now.

@ghost
Copy link
Author

ghost commented Sep 18, 2018

Tested with all 3 toolchains ? How this is fixing us ticker - it was disabled - so reenabling with reworking the us ticker to use different peripheral ticker ?

Yes, tested with all 3 toolchains.
To enable the feature US_TICKER, file is newly implemented with Timer B, which has proper clock prescale and free running after match interrupt.
Old us_ticker driver file (Timer A) is producing up to 100us tolerance, which causes to fail US_TICKER feature.
That is why we have changed the peripheral ticker A to B.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

To enable the feature US_TICKER, file is newly implemented with Timer B, which has proper clock prescale and free running after match interrupt.
Old us_ticker driver file (Timer A) is producing up to 100us tolerance, which causes to fail US_TICKER feature.
That is why we have changed the peripheral ticker A to B.

This is good info to have (exactly what I was asking), can you add it to the commit message?

Ganesh Ramachandran added 2 commits September 19, 2018 10:37
Added usticker feature
7504050 
To enable the feature US_TICKER, file is newly implemented with Timer B, which has proper clock prescale and free running after match interrupt.
Old us_ticker driver file (Timer A) is producing up to 100us tolerance, which causes to fail US_TICKER feature.
Hence, changed the peripheral ticker A to B.
Implemented us_ticker free()
cd618e6
@ghost
Copy link
Author

ghost commented Sep 19, 2018

This is good info to have (exactly what I was asking), can you add it to the commit message?

Added to commit message and Rebased.

@0xc0170 0xc0170 requested a review from a team September 19, 2018 10:18
@jamesbeyond
Copy link
Contributor

Hi @ganesh-ramachandran,
Due to our CI will not cover your target, could you attach the test log as a proof of implementation correctness?
mbed test -t <toolchain> -m TMPM066 -n tests-mbed_hal-common_ticker*,tests-mbed_hal-us_ticker*
more info about usticker tests can be found at HERE if required

@ghost
Copy link
Author

ghost commented Sep 19, 2018

Due to our CI will not cover your target, could you attach the test log as a proof of implementation correctness?

Hi @jamesbeyond, Please find below the ticker test log.
M066_ARM_TestResults.txt
M066_GCC_ARM_TestResults.txt
M066_IAR_TestResults.txt

jamesbeyond
jamesbeyond approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3257
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8149/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2863
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8149/

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Test : SUCCESS

Build number : 3066
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8149/3066

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : SUCCESS

Build number : 2874
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8149/

@cmonr cmonr merged commit 866018b into ARMmbed:master Oct 8, 2018
@ghost ghost deleted the m066_usticker-new_feature branch October 9, 2018 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @jamesbeyond @mbed-ci @NirSonnenschein @cmonr