Skip to content

Lora: Fix ADRAckReq #8054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

Lora: Fix ADRAckReq #8054

merged 1 commit into from
Sep 19, 2018

Conversation

kivaisan
Copy link
Contributor

Description

This commit fixes two bugs related to ADRAckReq:

  • adr_ack_counter must be incremented for all uplink messages (not just confirmed)
  • When ADR_ACK_LIMIT + ADR_ACK_DELAY has been reached, stack decreased used
    datarate twice.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

@AnttiKauppila @hasnainvirk @kjbracey-arm please review.

Lora: Fix ADRAckReq
782e470 
This commit fixes two bugs related to ADRAckReq:
- adr_ack_counter must be incremented for all uplink messages (not just confirmed)
- When ADR_ACK_LIMIT + ADR_ACK_DELAY has been reached, stack decreased used
  datarate twice.
@cmonr
Copy link
Contributor

cmonr commented Sep 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3105
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8054/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Exporter Build : SUCCESS

Build number : 2712
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8054/

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Test : SUCCESS

Build number : 2894
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8054/2894

@0xc0170 0xc0170 merged commit d8ec21a into ARMmbed:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@hasnainvirk hasnainvirk hasnainvirk approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kivaisan @cmonr @mbed-ci @0xc0170 @kjbracey @AnttiKauppila @hasnainvirk @adbridge