-
Notifications
You must be signed in to change notification settings - Fork 3k
nRF5x: pass ram linker start/length from config system #7957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for fixing that config system bug. Nice diff! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for tools changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@andrewleech In light of #7959 could you recommend how this should be merged? |
I've using both of these MR's together in my working branch, they're quite complimentary. This MR allows the project to set where the start address should be, the other one ensures that the correct start address is passed to the softdevice. I did consider making the other one work from this config system define rather than the linker element, but decided to leave it as the linker symbol as it's a smaller change to the existing nordic code and it should be safer, the symbol used is just in nordic linker scripts so is less likely to be accidentally changed in a breaking way than the config system symbol which is used for all targets. |
This needs a rebase, will be scheduled for CI afterwards |
Values like `target.mbed_rom_start` were being replaced by None and then ignored.
0288af6
to
f553f26
Compare
… settings in linker
f553f26
to
a0d7d4e
Compare
@0xc0170 I've rebased, should be good to go. The travis failure above looks pretty unrelated:
|
/morph build |
Build : SUCCESSBuild number : 3175 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2773 |
Test : SUCCESSBuild number : 2980 |
/morph mbed2-build |
Description
The ram start and length settings can already be defined in
targets.json
withmbed_ram_start
andmbed_ram_size
etc.These are supposed to be used in nrf5x targets to specify in the linker how much ram is set aside for the softdevice. Unfortunately the linker files have these values defined in directly so they can't be overridden by the target settings.
This PR fixes the problem by simply checking if the defines are already set before setting them in the linker scripts.
There was also a minor bug in the python config handler where these boot-loader target settings in were being overridden by a later part of the config system with
None
. This is also fixed.Pull request type