Skip to content

Travis: fix astyle report (-/+ files) #7898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 27, 2018

Description

Touching few files from various area, the changes are minimal.

Test for #7897 (to confirm this is the issue currently, recent PR shows only numbers so either the number has not changed or not working). This is important to make working , no more + number in the PR 👍

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 changed the title Fix astyle common Fix coding style in platform/drivers/rtos Aug 27, 2018
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 27, 2018

AStyle only reports the total number (should be - few files).

Master reports 553 files, here we got 529 files so negative number should be reported here

@0xc0170 0xc0170 requested a review from geky August 27, 2018 13:08
@0xc0170 0xc0170 force-pushed the fix_astyle_common branch 2 times, most recently from 1b3987d to 88751a8 Compare August 27, 2018 14:57
@0xc0170 0xc0170 force-pushed the fix_astyle_common branch from 88751a8 to 6ece6aa Compare August 27, 2018 15:59
@0xc0170 0xc0170 force-pushed the fix_astyle_common branch 3 times, most recently from 45ac626 to a4065cb Compare August 29, 2018 11:00
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 29, 2018

Looks like Travis astyle report is fixed Passed, 531 files (-24 files)

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 29, 2018

Ready for reviews !

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches in the astyle script 👍

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 20, 2018

Will rebase after 5.10.1, and update it

@0xc0170 0xc0170 force-pushed the fix_astyle_common branch from a4065cb to f1f16e5 Compare October 9, 2018 19:21
@0xc0170 0xc0170 changed the title Fix coding style in platform/drivers/rtos Travis: fix astyle report (-/+ files) Oct 9, 2018
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 9, 2018

Rescoped this PR. It now only fixes Travis AStyle report. I'll send the files separately in another PR

@cmonr Please review

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3300
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7898/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Oct 9, 2018

ci-morph-mbed2-build failed because the ARM license server is down.

xD

ಠ_ಠ

@cmonr
Copy link
Contributor

cmonr commented Oct 9, 2018

Arm License network issues, now fixed.
Relaunching.

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Oct 9, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

@cmonr cmonr merged commit dc4a52c into ARMmbed:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants