Skip to content

Fix pin names of MIMXRT1050 I2C pins #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Conversation

alrodlim
Copy link
Contributor

Description

Fixed the I2C pin mappings of MIMXRT1050 to the correct I/O pads.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 changed the title fixed pin names of MIMXRT1050 I2C pins Fix pin names of MIMXRT1050 I2C pins Sep 20, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Build : FAILURE

Build number : 3149
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7896/

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

Please review the failure (those pins used should be first defined)

@alrodlim
Copy link
Contributor Author

I have fixed the problem by moving the I2C pins definitions after A4 and A5 are defined.

@cmonr
Copy link
Contributor

cmonr commented Sep 24, 2018

@alrodlim The unit test are a new addition. The failure is being fixed in another PR, and doesn't appear to be caused by this PR.

@unsignedint
Copy link

Just FYI, I noticed the same issue with this target.. this fix LGTM 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3178
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7896/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 29, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit b1011bf into ARMmbed:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants