Skip to content

Add tests for synchronous dns #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

jarlamsa
Copy link
Contributor

Description

Add test cases for synchronous dns.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 24, 2018 09:30
@jarlamsa
Copy link
Contributor Author

@0xc0170 Was there some issue in Travis last week, the logs look like some issues in the Travis job itself?

@jarlamsa
Copy link
Contributor Author

@mikaleppanen @SeppoTakalo @kjbracey-arm please review

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2018

@0xc0170 Was there some issue in Travis last week, the logs look like some issues in the Travis job itself?

Yes, it looks fine now

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me (besides naming of the test cases being upper case - but shall be addressed by separate fix).

One change - can you review astyle travis job (one line should be fixed)

@jarlamsa jarlamsa force-pushed the synchronous_dns_tests branch 2 times, most recently from 9e4f07a to 14c0a11 Compare August 27, 2018 10:27
@jarlamsa
Copy link
Contributor Author

Done. It would be easier to notice if there is something to be done in the astyle if it would directly report that the check wasn't successful, now you basically need to separately open the logs each time to see if there is something wrong.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2018

Done. It would be easier to notice if there is something to be done in the astyle if it would directly report that the check wasn't successful, now you basically need to separately open the logs each time to see if there is something wrong.

I'll look at this, it should have reported how many files needs changing +/- , we will fix

To add some details - we are currently still cleaning up the code base. Errors in the style will come most probably in the next release (still around 500 files to be cleaned). I'll send another PR to decrease the count.

@jarlamsa jarlamsa force-pushed the synchronous_dns_tests branch from 14c0a11 to 0c758b9 Compare August 27, 2018 12:06
@jarlamsa
Copy link
Contributor Author

@0xc0170 Can the CI be initiated for this PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2018

Build : SUCCESS

Build number : 2941
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7879/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

@jarlamsa
Copy link
Contributor Author

Test was successful but I can't even see exporter being built at all. Is the CI working as expected?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2018

/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2018

License server error (fixed now)

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants