-
Notifications
You must be signed in to change notification settings - Fork 3k
Add tests for synchronous dns #7879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xc0170 Was there some issue in Travis last week, the logs look like some issues in the Travis job itself? |
@mikaleppanen @SeppoTakalo @kjbracey-arm please review |
Yes, it looks fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me (besides naming of the test cases being upper case - but shall be addressed by separate fix).
One change - can you review astyle travis job (one line should be fixed)
9e4f07a
to
14c0a11
Compare
Done. It would be easier to notice if there is something to be done in the astyle if it would directly report that the check wasn't successful, now you basically need to separately open the logs each time to see if there is something wrong. |
I'll look at this, it should have reported how many files needs changing +/- , we will fix To add some details - we are currently still cleaning up the code base. Errors in the style will come most probably in the next release (still around 500 files to be cleaned). I'll send another PR to decrease the count. |
14c0a11
to
0c758b9
Compare
@0xc0170 Can the CI be initiated for this PR? |
/morph build |
Build : SUCCESSBuild number : 2941 Triggering tests/morph test |
Test : SUCCESSBuild number : 2690 |
Test was successful but I can't even see exporter being built at all. Is the CI working as expected? |
/morph export-build |
Exporter Build : FAILUREBuild number : 2562 |
License server error (fixed now) /morph export-build |
Exporter Build : SUCCESSBuild number : 2563 |
Description
Add test cases for synchronous dns.
Pull request type