-
Notifications
You must be signed in to change notification settings - Fork 3k
Add required header file and namespace element instead add all. #7864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fdcd51d
EventQueue: Add required header file and namespace element instead ad…
3d5ec66
RTOS: Add required header file and namespace element instead add all
f55b929
ATCmdParser: Added namespace std for va_list
1d23843
Platform: Add required header file and namespace element instead add all
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,10 @@ | |
#ifndef MBED_ATCMDPARSER_H | ||
#define MBED_ATCMDPARSER_H | ||
|
||
#include "mbed.h" | ||
#include <cstdarg> | ||
#include "Callback.h" | ||
#include "NonCopyable.h" | ||
#include "FileHandle.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The latest build points to this file, seems like some includes are missing and build fails There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed: std namespace was missing |
||
|
||
namespace mbed { | ||
|
||
|
@@ -202,7 +203,7 @@ class ATCmdParser : private NonCopyable<ATCmdParser> { | |
*/ | ||
bool send(const char *command, ...) MBED_PRINTF_METHOD(1, 2); | ||
|
||
bool vsend(const char *command, va_list args); | ||
bool vsend(const char *command, std::va_list args); | ||
|
||
/** | ||
* Receive an AT response | ||
|
@@ -220,7 +221,7 @@ class ATCmdParser : private NonCopyable<ATCmdParser> { | |
*/ | ||
bool recv(const char *response, ...) MBED_SCANF_METHOD(1, 2); | ||
|
||
bool vrecv(const char *response, va_list args); | ||
bool vrecv(const char *response, std::va_list args); | ||
|
||
/** | ||
* Write a single byte to the underlying stream | ||
|
@@ -265,7 +266,7 @@ class ATCmdParser : private NonCopyable<ATCmdParser> { | |
*/ | ||
int printf(const char *format, ...) MBED_PRINTF_METHOD(1, 2); | ||
|
||
int vprintf(const char *format, va_list args); | ||
int vprintf(const char *format, std::va_list args); | ||
|
||
/** | ||
* Direct scanf on underlying stream | ||
|
@@ -277,7 +278,7 @@ class ATCmdParser : private NonCopyable<ATCmdParser> { | |
*/ | ||
int scanf(const char *format, ...) MBED_SCANF_METHOD(1, 2); | ||
|
||
int vscanf(const char *format, va_list args); | ||
int vscanf(const char *format, std::va_list args); | ||
|
||
/** | ||
* Attach a callback for out-of-band data | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vaargs types are in
#include <cstdarg>
How is it included ?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform/ATCmdParser.h
includescstdarg
https://github.com/ARMmbed/mbed-os/pull/7864/files/1d23843833c19d913601f40e34ef3880f0a3a77c#diff-61ea3747ffa004896edb10ecbdcdc1a0R23