Skip to content

Removing default flow control for MTB_LAIRD_BL652 #7861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Removing default flow control for MTB_LAIRD_BL652 #7861

merged 1 commit into from
Oct 8, 2018

Conversation

ashok-rao
Copy link
Contributor

Description

Flow control is enabled by default for this target that derives from nRF52. It needs to be disabled for the MTB_LAIRD_BL652 module target since this module does not need flow control enabled.

Verified with printf() messages on the serial terminal. WIth FC = "RTSCTS" (i.e. default in Mbed OS today) there are no debug messages sent over the UART to terminal.

@cmonr or @0xc0170 : Please let me know what tests would be required for this. I can attach relevant logs. Thanks.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@ashok-rao ashok-rao changed the title Removing default flow control for BL652 Removing default flow control for MTB_LAIRD_BL652 Aug 22, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 23, 2018

Any test should do as would test the console uart

@marcuschangarm
Copy link
Contributor

@ashok-rao
The default behavior is null so you can just remove the line completely like for the other targets that don't require flow control.

@ashok-rao
Copy link
Contributor Author

@cmonr ..over to you..

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3255
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7861/

Triggering tests

/morph test
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants