-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32L4 : code cleanup in MSI SetSysClock #7787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - has this been tested ok on boards with LSE ?
/morph build |
@jeromecoutant Fyi, I stopped your build command. Maintainers are the only ones allowed to start builds due to how resource intensive those jobs are, especially when getting PRs ready during release periods. |
We are now progressing with needs: CI PR, this will be restarted. |
/morph build |
Build : FAILUREBuild number : 3013 |
Weird. @ARMmbed/mbed-os-test FYI^^^ /morph build |
Sorry, stopping the restart. Prioritizing PRs going into 5.10-rc2 and 5.9.7. |
/morph build |
Build : SUCCESSBuild number : 3049 Triggering tests/morph test |
Test : SUCCESSBuild number : 2824 |
Exporter Build : SUCCESSBuild number : 2666 |
Description
This follow #7647 discussion
For STM32L4 familly, clock configuration can use MSI (multispeed internal RC oscillator clock).
When a 32.768 kHz external oscillator (LSE) is present, it is possible to configure the MSI in a PLL-mode.
When configured in PLL-mode, the MSI automatically calibrates itself thanks to the LSE.
This setting was set 2 times during MSI configuration and even if LSE is not present.
@mattbrown015
Pull request type