Skip to content

STM32L4 : code cleanup in MSI SetSysClock #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

This follow #7647 discussion

For STM32L4 familly, clock configuration can use MSI (multispeed internal RC oscillator clock).
When a 32.768 kHz external oscillator (LSE) is present, it is possible to configure the MSI in a PLL-mode.
When configured in PLL-mode, the MSI automatically calibrates itself thanks to the LSE.

This setting was set 2 times during MSI configuration and even if LSE is not present.

@mattbrown015

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@adbridge adbridge requested a review from a team August 14, 2018 11:42
Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - has this been tested ok on boards with LSE ?

@jeromecoutant
Copy link
Collaborator Author

/morph build

@cmonr
Copy link
Contributor

cmonr commented Sep 4, 2018

@jeromecoutant Fyi, I stopped your build command. Maintainers are the only ones allowed to start builds due to how resource intensive those jobs are, especially when getting PRs ready during release periods.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2018

We are now progressing with needs: CI PR, this will be restarted.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 5, 2018

Build : FAILURE

Build number : 3013
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7787/

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

[DEBUG] Output: Fatal error: A1023E: File "/tmp/file1QOyif" could not be opened: No such file or directory

Weird. @ARMmbed/mbed-os-test FYI^^^

/morph build

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

Sorry, stopping the restart. Prioritizing PRs going into 5.10-rc2 and 5.9.7.

@cmonr
Copy link
Contributor

cmonr commented Sep 11, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2018

Build : SUCCESS

Build number : 3049
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7787/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

@0xc0170 0xc0170 merged commit b97ac0c into ARMmbed:master Sep 17, 2018
@jeromecoutant jeromecoutant deleted the PR_MSI_LSE branch September 17, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants