Skip to content

LoRa: Fix MAC initialization for connection with parameters #7770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2018
Merged

LoRa: Fix MAC initialization for connection with parameters #7770

merged 1 commit into from
Aug 21, 2018

Conversation

kivaisan
Copy link
Contributor

Description

LoRaMAC was not initialized properly if application called
connect(const lorawan_connect_t &connect);

This causes problems for example in case where application
first disconnects and then reconnects as counter values are not
initialized.

This fixes #7759.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

LoRaMAC was not initialized properly if application called
connect(const lorawan_connect_t &connect);

This causes problems for example in case where application
first disconnects and then reconnects as counter values are not
initialized.
@kivaisan
Copy link
Contributor Author

@hasnainvirk @AnttiKauppila @kjbracey-arm please review.

@cmonr cmonr requested a review from kjbracey August 13, 2018 14:42
@cmonr
Copy link
Contributor

cmonr commented Aug 13, 2018

Going to try and target this for the next patch, but it's possible this might be fixing something that's going in 5.10.

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2784
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7770/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@kivaisan
Copy link
Contributor Author

Test failure does not seem to relate this PR. Could you please restart the test?

@adbridge
Copy link
Contributor

/morph test

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

CI had an issue a few hours ago.
/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

/morph test

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

Restarting since the test hit an issue that is now fixed in master.

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

@cmonr cmonr merged commit 08afaf2 into ARMmbed:master Aug 21, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
LoRa: Fix MAC initialization for connection with parameters
@cmonr
Copy link
Contributor

cmonr commented Aug 23, 2018

Ended up being based off of prior changes going into 5.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoRaWAN: Downlinks Fail After Disconnecting and Connecting Again
8 participants