-
Notifications
You must be signed in to change notification settings - Fork 3k
LoRa: Fix MAC initialization for connection with parameters #7770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LoRaMAC was not initialized properly if application called connect(const lorawan_connect_t &connect); This causes problems for example in case where application first disconnects and then reconnects as counter values are not initialized.
@hasnainvirk @AnttiKauppila @kjbracey-arm please review. |
Going to try and target this for the next patch, but it's possible this might be fixing something that's going in 5.10. /morph build |
Build : SUCCESSBuild number : 2784 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2415 |
Test : FAILUREBuild number : 2521 |
Test failure does not seem to relate this PR. Could you please restart the test? |
/morph test |
CI had an issue a few hours ago. |
Test : FAILUREBuild number : 2541 |
/morph test |
Test : FAILUREBuild number : 2564 |
/morph test |
Restarting since the test hit an issue that is now fixed in master. /morph test |
Test : SUCCESSBuild number : 2574 |
LoRa: Fix MAC initialization for connection with parameters
Ended up being based off of prior changes going into 5.10. |
Description
LoRaMAC was not initialized properly if application called
connect(const lorawan_connect_t &connect);
This causes problems for example in case where application
first disconnects and then reconnects as counter values are not
initialized.
This fixes #7759.
Pull request type