Clear CONN_IN_PROGRESS flag after incomplete connect() #7661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failed of its own accord) would prevent futher connect()'s due to the CONN_IN_PROGRESS_FLAG remaining set. This change clears that flag in the two cases described.
kivaisan
approved these changes
Aug 1, 2018
hasnainvirk
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
Looks like a nice catch of an edge case and really good solution. Thanks @EnsilicaEdd . +1
0xc0170
approved these changes
Aug 1, 2018
|
/morph build |
Build : SUCCESSBuild number : 2715 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2348 |
Test : SUCCESSBuild number : 2446 |
|
/morph mbed2-build |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
…te_connect Clear CONN_IN_PROGRESS flag after incomplete connect()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An incomplete
connect()(either abandoned with adisconnect()or just failed of its own accord) would cause subsequent calls toconnect()to fail withLORAWAN_STATUS_BUSYdue to theCONN_IN_PROGRESS_FLAGremaining set in_ctrl_flags.This change clears that flag in the two cases described.
Pull request type