Skip to content

Remove device emac check from emac greentea tests #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Remove device emac check from emac greentea tests #7655

merged 1 commit into from
Aug 1, 2018

Conversation

mikaleppanen
Copy link

Description

DEVICE_EMAC is defined only for boards with default Ethernet emac. It is not defined for example for Realtek RTL8195AM board that does not have Ethernet. Removed the check for device emac from emac greentea tests.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

DEVICE_EMAC is defined only for boards with default Ethernet emac.
It is not defined for example for Realtek RTL8195AM board that
does not have Ethernet. Removed the check for device emac from emac
greentea tests.
@mikaleppanen
Copy link
Author

@juhaylinen After this fix, there should not be need to define override for target device EMAC when building emac greentea tests.

@0xc0170 0xc0170 changed the title Removed device emac check from emac greentea tests Remove device emac check from emac greentea tests Jul 31, 2018
@0xc0170 0xc0170 requested a review from a team July 31, 2018 10:26
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2702
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7655/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2018

@0xc0170 0xc0170 merged commit 1a7ff86 into ARMmbed:master Aug 1, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Remove device emac check from emac greentea tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants