Remove device emac check from emac greentea tests #7655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEVICE_EMAC is defined only for boards with default Ethernet emac. It is not defined for example for Realtek RTL8195AM board that does not have Ethernet. Removed the check for device emac from emac greentea tests.
|
@juhaylinen After this fix, there should not be need to define override for target device EMAC when building emac greentea tests. |
0xc0170
changed the title
0xc0170
approved these changes
Jul 31, 2018
juhaylinen
approved these changes
Jul 31, 2018
SeppoTakalo
approved these changes
Jul 31, 2018
|
/morph build |
Build : SUCCESSBuild number : 2702 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2331 |
Test : SUCCESSBuild number : 2433 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
Remove device emac check from emac greentea tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DEVICE_EMAC is defined only for boards with default Ethernet emac. It is not defined for example for Realtek RTL8195AM board that does not have Ethernet. Removed the check for device emac from emac greentea tests.
Pull request type