Skip to content

Makes Greentea TCP test cases to timeout less in connection errors #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2018
Merged

Makes Greentea TCP test cases to timeout less in connection errors #7578

merged 1 commit into from
Jul 26, 2018

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Jul 23, 2018 •
edited
Loading

Description

Makes Greentea TCP test cases to timeout less in connection errors

Made to prevent timeout if a single test case fails. The goal is that
each test case might wait only half of the remaining time reserved for
running TCP test cases.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@VeijoPesonen
Copy link
Contributor Author

VeijoPesonen commented Jul 23, 2018 •
edited
Loading

@SeppoTakalo, @jarlamsa please check.

@0xc0170 0xc0170 requested a review from a team July 23, 2018 09:37
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2018 •
edited
Loading

@VeijoPesonen Can you add some more context to the commit msg (included here in the comment but not part of the code change) ?

Good questions to be asked : if this is fixing something, how and why is it fixing?

Makes Greentea TCP test cases to timeout less in connection errors
dd6ec03 
Made to prevent timeout if a single test case fails. The goal is that
each test case might wait only half of the remaining time reserved for
running TCP test cases.
@VeijoPesonen
Copy link
Contributor Author

VeijoPesonen commented Jul 26, 2018 •
edited
Loading

@0xc0170 Sorry for the bad explanation. Hopefully the latest commit message provides sufficient information.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Build : SUCCESS

Build number : 2675
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7578/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Exporter Build : SUCCESS

Build number : 2310
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7578/

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Test : SUCCESS

Build number : 2413
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7578/2413

@cmonr cmonr merged commit 5d4f636 into ARMmbed:master Jul 26, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 26, 2018
@VeijoPesonen VeijoPesonen deleted the conn_failure_tolerance branch July 27, 2018 04:53
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7578 from VeijoPesonen/conn_failure_tolerance
0d36dae 
Makes Greentea TCP test cases to timeout less in connection errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VeijoPesonen @0xc0170 @mbed-ci @SeppoTakalo @cmonr