Skip to content

realtek rtl8195am remove DEVICE_EMAC #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

M-ichae-l
Copy link
Contributor

@M-ichae-l M-ichae-l commented Jul 19, 2018

Description

Pull request type

[X] Fix

1, remove DEVICE_EMAC for wifi feature
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 19, 2018

Why it was defined first place ? (why is this being removed now)

@M-ichae-l
Copy link
Contributor Author

@0xc0170
Please refer to #7257. A device should enable EMAC flag in targets.json only if its pure Ethernet. Rtl8195am is not pure Ethernet.
The DEVICE_EMAC macro should be removed in targets.json and related files.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

Thanks ! How is CONFIG_MBED_ENABLED related?

My questions might be answered by the commit message but could not find it there.

@M-ichae-l
Copy link
Contributor Author

@0xc0170
CONFIG_MBED_ENABLED is the macro that only used by RTL8195AM for internal SDK sync.

@SeppoTakalo
Copy link
Contributor

@0xc0170 Seems like we don't have generic "this build is Mbed OS" flag available, so Realtek has been using this CONFIG_MBED_ENABLED macro, which already is enabled by their target.

Closest alternative would be MBED_CONF_RTOS_PRESENT but that could be disable by Mbed 2 builds.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 24, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Jul 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

Build : SUCCESS

Build number : 2665
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7551/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 24, 2018

@0xc0170 0xc0170 merged commit 7adfcbe into ARMmbed:master Jul 25, 2018
@M-ichae-l M-ichae-l deleted the realtek-rtl8195am-remove-DEVICE_EMAC branch July 30, 2018 03:51
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
…ve-DEVICE_EMAC

realtek rtl8195am remove DEVICE_EMAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants