Skip to content

STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018
Merged

STM32: Improve GPIO IRQ edge detection when waking from deepsleep #7510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions targets/TARGET_STM/gpio_irq_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,30 @@ static void handle_interrupt_in(uint32_t irq_index, uint32_t max_num_pin_line)
continue;
}

// Check which edge has generated the irq
if ((gpio->IDR & pin) == 0) {
irq_handler(gpio_channel->channel_ids[gpio_idx], IRQ_FALL);
// Trying to discern which edge caused the IRQ
gpio_irq_event event = IRQ_NONE;
if (LL_EXTI_IsEnabledFallingTrig_0_31(pin) && !LL_EXTI_IsEnabledRisingTrig_0_31(pin)) {
// Only the fall handler is active, so this must be a falling edge
event = IRQ_FALL;
} else if (LL_EXTI_IsEnabledRisingTrig_0_31(pin) && !LL_EXTI_IsEnabledFallingTrig_0_31(pin)) {
// Only the rise handler is active, so this must be a rising edge
event = IRQ_RISE;
} else {
irq_handler(gpio_channel->channel_ids[gpio_idx], IRQ_RISE);
// Ambiguous as to which edge caused the IRQ
//
// The state of the pin could/should indicate which edge
// has occurred but this can go wrong if the IRQ caused a
// transition from a low power mode. In some circumstances
// only the trailing edge callback will be called.
if ((gpio->IDR & pin) == 0) {
event = IRQ_FALL;
} else {
event = IRQ_RISE;
}
}

irq_handler(gpio_channel->channel_ids[gpio_idx], event);

return;
}
}
Expand Down