Skip to content

Tools: Correct cmse lib creating with make_gcc_arm exporter #7500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

This is an interesting one: we run the constructor, but not the link
method from the mbedToolchain classes in any exporter. As such, the
toolchains must make sure to include all of the important flags during
the __init__ method.

This PR puts another, quite important, flag into the constructor.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@@ -234,10 +237,6 @@ def link(self, output, objects, libraries, lib_dirs, mem_map):
map_file = splitext(output)[0] + ".map"
cmd = self.ld + ["-o", output, "-Wl,-Map=%s" % map_file] + objects + ["-Wl,--start-group"] + libs + ["-Wl,--end-group"]
# Create Secure library

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should also be removed

Copy link
Contributor Author

@theotherjimmy theotherjimmy Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (via rebase).

@theotherjimmy theotherjimmy force-pushed the fix-gcc-v8m-export branch 3 times, most recently from 610275e to 6178af3 Compare July 12, 2018 15:47
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

Build : SUCCESS

Build number : 2599
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7500/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 13, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 14, 2018

@cmonr cmonr merged commit 9667b5e into ARMmbed:master Jul 14, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 14, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Tools: Correct cmse lib creating with make_gcc_arm exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants