Tools: Correct cmse lib creating with make_gcc_arm exporter #7500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/toolchains/gcc.py
Outdated
| @@ -234,10 +237,6 @@ def link(self, output, objects, libraries, lib_dirs, mem_map): | |||
| map_file = splitext(output)[0] + ".map" | |||
| cmd = self.ld + ["-o", output, "-Wl,-Map=%s" % map_file] + objects + ["-Wl,--start-group"] + libs + ["-Wl,--end-group"] | |||
| # Create Secure library | |||
There was a problem hiding this comment.
This comment should also be removed
There was a problem hiding this comment.
Fixed (via rebase).
theotherjimmy
force-pushed
the
fix-gcc-v8m-export
branch
3 times, most recently
from
610275e to
6178af3
Compare
theotherjimmy
force-pushed
the
fix-gcc-v8m-export
branch
from
6178af3 to
ef7b466
Compare
0xc0170
approved these changes
Jul 13, 2018
|
/morph build |
Build : SUCCESSBuild number : 2599 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2243 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 2247 |
Test : SUCCESSBuild number : 2352 |
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Aug 22, 2018
Tools: Correct cmse lib creating with make_gcc_arm exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an interesting one: we run the constructor, but not the link
method from the
mbedToolchainclasses in any exporter. As such, thetoolchains must make sure to include all of the important flags during
the
__init__method.This PR puts another, quite important, flag into the constructor.
Pull request type