-
Notifications
You must be signed in to change notification settings - Fork 3k
Tools: Correct cmse lib creating with make_gcc_arm exporter #7500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tools/toolchains/gcc.py
Outdated
@@ -234,10 +237,6 @@ def link(self, output, objects, libraries, lib_dirs, mem_map): | |||
map_file = splitext(output)[0] + ".map" | |||
cmd = self.ld + ["-o", output, "-Wl,-Map=%s" % map_file] + objects + ["-Wl,--start-group"] + libs + ["-Wl,--end-group"] | |||
# Create Secure library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should also be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (via rebase).
610275e
to
6178af3
Compare
6178af3
to
ef7b466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/morph build |
Build : SUCCESSBuild number : 2599 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2243 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2247 |
Test : SUCCESSBuild number : 2352 |
Tools: Correct cmse lib creating with make_gcc_arm exporter
Description
This is an interesting one: we run the constructor, but not the link
method from the
mbedToolchain
classes in any exporter. As such, thetoolchains must make sure to include all of the important flags during
the
__init__
method.This PR puts another, quite important, flag into the constructor.
Pull request type