-
Notifications
You must be signed in to change notification settings - Fork 3k
EFM32: fix weak PeripheralPins configuration #7491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFM32: fix weak PeripheralPins configuration #7491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will wait for @stevew817 to ack before starting CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,7 +25,7 @@ | |||
|
|||
/************ADC***************/ | |||
/* The third "function" value is used to select the correct ADC channel */ | |||
const PinMap PinMap_ADC[] = { | |||
const PinMap __attribute__((weak)) PinMap_ADC[] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use MBED_WEAK
#7079 was merged, so please rebase and apply the same change for EFM32GG11. |
@stevew817 I can wait, right now it is not that urgent.
I will do it asap |
… overridable. See issue "ARMmbed#7424 (comment)"
@stevew817 I did the requested changes 😄 edit: I did the rebase to master but why does git thinks the "rebase commits" are new commits? Only the commit d1c313d8aff2aa4d89745380c3fb48010dedf0db is new... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I approve of the changes to the Silicon Labs part. However, to satisfy the mbed-os maintainers, you should take a look at the git rebase command instead of doing a merge. Rebasing your specific changes on top of master avoids all these superfluous commits in the PR log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I approve of the changes to the Silicon Labs part. However, to satisfy the mbed-os maintainers, you should take a look at the git rebase command instead of doing a merge. Rebasing your specific changes on top of master avoids all these superfluous commits in the PR log.
@DBS06 If you can't get rebase to work, I'd suggest checking out a new feature branch based off of master, cherry-picking your commits to go on top, and force-pushing the 'clean' branch to your PR branch on github. |
d1c313d
to
95d78df
Compare
…idable for target EFM32GG11.
@stevew817 Cleaned my branch while my lunch getting cold 😄 |
Great! I wholeheartedly approve 👍 |
@cmonr Done! |
/morph build |
Build : FAILUREBuild number : 2612 |
Looks like MBED_WEAK needs to come before the type in a variable declaration, or mbed_toolchain.h is not part of the include chain. |
@stevew817 |
/morph build |
Build : FAILUREBuild number : 2617 |
/morph build |
Build : SUCCESSBuild number : 2621 Triggering tests/morph test |
/morph mbed2-build |
/morph export-build |
Test : SUCCESSBuild number : 2370 |
Exporter Build : FAILUREBuild number : 2262 |
/morph export-build |
2 similar comments
/morph export-build |
/morph export-build |
/morph export-build @0xc0170 This might need some special attention tomorrow... |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2285 |
…pheralPins_overridable EFM32: fix weak PeripheralPins configuration
Description
PR for Issue #7424 .
Making the configuration tables weakly defined to be overridable.
This would be needed for i.e. custom targets which uses different Pin-Profiles as default defined.
Pull request type