Skip to content

DISCO_L496AG: change LED1 and LED2 pins #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2018
Merged

DISCO_L496AG: change LED1 and LED2 pins #7376

merged 2 commits into from
Jul 5, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Jun 29, 2018

Description

Change LED1 and LED2 pins assignments.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

jeromecoutant
jeromecoutant reviewed Jun 29, 2018
View reviewed changes
targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/TARGET_DISCO_L496AG/PinNames.h
LED1 = PB_13, // Green LD2 on board
LED2 = LED1,
LED1 = PA_5, // Green LD3 on board
LED2 = PB_13, // Green LD2 on board --> Warning: the state is reverted (1=OFF and 0=ON)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not coherent with PeripheralPins.c:
{PB_13, UART_3, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF7_USART3)}, // Connected to LED1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot the comments in this file. I will update it too. Thanks.

@bcostm bcostm force-pushed the dev_leds_disco_L496ag branch from 873d3db to b6beb74 Compare July 2, 2018 08:27
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

@jeromecoutant Please review after the update

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2499
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7376/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Exporter Build : FAILURE

Build number : 2145
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7376/

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

Test : SUCCESS

Build number : 2275
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7376/2275

@cmonr
Copy link
Contributor

cmonr commented Jul 3, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2018

Exporter Build : FAILURE

Build number : 2147
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7376/

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2018

/morph export-build

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Exporter Build : SUCCESS

Build number : 2168
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7376/

@cmonr cmonr merged commit 1941906 into ARMmbed:master Jul 5, 2018
@bcostm bcostm deleted the dev_leds_disco_L496ag branch July 6, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcostm @0xc0170 @mbed-ci @cmonr @jeromecoutant