-
Notifications
You must be signed in to change notification settings - Fork 3k
Tools: Detect Arm Compiler version using Component #7367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant Could you verify this fix? |
LGTM, will hold for @jeromecoutant's Ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Issue fixed.
By the way, before this patch, why the error detection didn't stop test execution?
@jeromecoutant Thanks for testing! For the "why not stop" you can see the original PR, #7247 |
/morph build |
Build : SUCCESSBuild number : 2490 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2129 |
Test : SUCCESSBuild number : 2265 |
/morph export-build |
Exporter Build : FAILUREBuild number : 2130 |
/morph export-build |
Exporter Build : FAILUREBuild number : 2133 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2143 |
Description
In an offline discussion, I found that the arm compiler may spit out:
instead of what I was expecting.
This PR fixes detection logic to use the component field instead of
the product field like I was using before.
Pull request type