Skip to content

Tools: Detect Arm Compiler version using Component #7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jun 28, 2018

Description

In an offline discussion, I found that the arm compiler may spit out:

Product: MDK Professional 5.22
Component: ARM Compiler 5.06 update 6 (build 750)

instead of what I was expecting.

This PR fixes detection logic to use the component field instead of
the product field like I was using before.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy
Copy link
Contributor Author

@jeromecoutant Could you verify this fix?

@cmonr cmonr requested a review from jeromecoutant June 29, 2018 00:46
@cmonr
Copy link
Contributor

cmonr commented Jun 29, 2018

LGTM, will hold for @jeromecoutant's Ok.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Issue fixed.

By the way, before this patch, why the error detection didn't stop test execution?

@theotherjimmy
Copy link
Contributor Author

@jeromecoutant Thanks for testing!

For the "why not stop" you can see the original PR, #7247

@cmonr
Copy link
Contributor

cmonr commented Jun 30, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

Build : SUCCESS

Build number : 2490
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7367/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 30, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2018

@cmonr cmonr merged commit 9c4c630 into ARMmbed:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants