Cellular: improved observing of disconnect for callbacks. #7341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
suggested changes
Jun 27, 2018
| err = _at.set_urc_handler("+CGEV:", callback(this, &AT_CellularNetwork::urc_cgev)); | ||
| if (err == NSAPI_ERROR_OK) { | ||
| _at.lock(); | ||
| _at.cmd_start("AT+CGEREP=2"); |
There was a problem hiding this comment.
Any idea how well mode=2 is supported, for our needs mode=1 is good enough..?
| void AT_CellularNetwork::urc_cgev() | ||
| { | ||
| char buf[13]; | ||
| if (_at.read_string(buf, 13) < 8 ) { // smallest string length we wan't to compare is 8 |
| @@ -61,6 +61,7 @@ AT_CellularNetwork::~AT_CellularNetwork() | |||
| } | |||
|
|
|||
| _at.remove_urc_handler("NO CARRIER", callback(this, &AT_CellularNetwork::urc_no_carrier)); | |||
| _at.remove_urc_handler("+CGEV:", callback(this, &AT_CellularNetwork::urc_cgev)); | |||
There was a problem hiding this comment.
Should also be removed in disconnect()
jarvte
force-pushed
the
packet_domain_urc_for_disconnect_callback
branch
from
d3ae518 to
5ccfd9f
Compare
AriParkkila
approved these changes
Jun 27, 2018
0xc0170
approved these changes
Jun 27, 2018
|
/morph build |
Build : SUCCESSBuild number : 2457 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2087 |
Test : SUCCESSBuild number : 2234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the way we notice when modem is disconnected so we can call callbacks for application and inform about disconnection.
@AriParkkila @mirelachirica please review.
Internal ref to defect: IOTCELL-1086
Pull request type