-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: Add setScanParams overload to the Gap API #7262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
features/FEATURE_BLE/ble/Gap.h
Outdated
*/ | ||
ble_error_t setScanParams(const GapScanningParams& scanningParams) { | ||
ble_error_t rc; | ||
if (((rc = _scanningParams.setInterval(scanningParams.getInterval())) == BLE_ERROR_NONE) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you delegate the call to setScanParams(uint16_t, uint16_t, uint16_t, bool)
?
/morph build |
@ARMmbed/mbed-os-maintainers This is a tricky PR to label. A new function was added, but it's really just a mapping to a missing overloaded function call. I don't think it's enough of a user-facing change to warrant it going to 5.10. Thoughts? |
Build : SUCCESSBuild number : 2429 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2058 |
Going to re-enqueue the export build since the failure appears to be something related to multiply-defined symbols, a CI issue we haven't seen in a while (ping @studavekar). /morph export-build |
Exporter Build : FAILUREBuild number : 2059 |
There's absolutely no rush to get this in. This is just a minor quality improvement. |
CI error, restarting /morph export-build |
Test : SUCCESSBuild number : 2209 |
Exporter Build : FAILUREBuild number : 2060 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2063 |
Description
Adding a missing overload for setScanParams so that it matches the advertising API calls.
Pull request type