Skip to content

BLE: Add setScanParams overload to the Gap API #7262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2018

Conversation

paul-szczepanek-arm
Copy link
Member

Description

Adding a missing overload for setScanParams so that it matches the advertising API calls.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm requested a review from pan- June 19, 2018 14:22
0xc0170
0xc0170 previously approved these changes Jun 19, 2018
*/
ble_error_t setScanParams(const GapScanningParams& scanningParams) {
ble_error_t rc;
if (((rc = _scanningParams.setInterval(scanningParams.getInterval())) == BLE_ERROR_NONE) &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delegate the call to setScanParams(uint16_t, uint16_t, uint16_t, bool) ?

@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

@ARMmbed/mbed-os-maintainers This is a tricky PR to label.

A new function was added, but it's really just a mapping to a missing overloaded function call. I don't think it's enough of a user-facing change to warrant it going to 5.10. Thoughts?

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2429
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7262/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 22, 2018

Going to re-enqueue the export build since the failure appears to be something related to multiply-defined symbols, a CI issue we haven't seen in a while (ping @studavekar).

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Jun 22, 2018

There's absolutely no rush to get this in. This is just a minor quality improvement.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2018

CI error, restarting

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@cmonr cmonr merged commit d18aa90 into ARMmbed:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants