Skip to content

Rename text region in ARM linker file for a few NXP CPUs #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

davidsaada
Copy link
Contributor

Description

In most of the linker files for the ARM toolchain, the text region has a uniform name LR_IROM1. However, a few Freescale/NXP boards had the LR_m_text name instead. Beside this being not uniform, it doesn't allow us to determine the text region size at run time (which is required in a few future tests). In addition, the LR_IROM1 name is referred to in a few Handbook documents (like Bootstrap or Flash) and the LR_m_text name deviates from this documentation.
This change currently has no effect on anything other than the linker files themselves (These names aren't mentioned in the code).

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 19, 2018

which is required in a few future tests

@davidsaada Thanks for fixing it. If this is going to be unified, we should document it and have this tested.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2382
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7242/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 19, 2018

/morph export-build

@davidsaada
Copy link
Contributor Author

Thanks for fixing it. If this is going to be unified, we should document it and have this tested.

Right. Will have separate PRs for it. Need to think of the test - It's not really a test, as the acceptance here is a successful build.

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants