Skip to content

STM32: Add comments for HAL_InitTick function #7225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2018
Merged

STM32: Add comments for HAL_InitTick function #7225

merged 2 commits into from
Jun 18, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Jun 15, 2018

Description

Add more comments for the HAL_InitTick function to explain this function is not intended to configure the SysTick but rather a HW timer used for timeouts only. I hope it is clearer, otherwise tell me...

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team June 15, 2018 09:25
0xc0170
0xc0170 previously approved these changes Jun 15, 2018
View reviewed changes
jeromecoutant
jeromecoutant previously approved these changes Jun 15, 2018
View reviewed changes
@bcostm bcostm dismissed stale reviews from jeromecoutant and 0xc0170 via 09b8b53 June 15, 2018 09:28
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2018

Build : SUCCESS

Build number : 2369
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7225/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2018

Exporter Build : SUCCESS

Build number : 2002
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7225/

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2018

Test : SUCCESS

Build number : 2158
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7225/2158

@cmonr
Copy link
Contributor

cmonr commented Jun 18, 2018

/morph uvisor-test

@cmonr cmonr merged commit f3e7497 into ARMmbed:master Jun 18, 2018
@bcostm bcostm deleted the fix_hal_tick_comment branch June 19, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant left review comments

Assignees
No one assigned
Labels
release-version: 5.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcostm @0xc0170 @mbed-ci @cmonr @jeromecoutant