Make CPU stats test conditional on new LP ticker #7004
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepikabhavnani
previously approved these changes
May 24, 2018
0xc0170
previously approved these changes
May 24, 2018
kjbracey
changed the title
Pending the new LP ticker HAL changes, we're still seeing test issues on the NRF51. On the assumption that the LP ticker PR will fix it, and knowing that it is currently lacking the necessary change to DEVICE_LPTICKER for this test, change the test now. This deactivates the test, and it will be reenabled when the LP ticker PR lands, rather than being deactivated by it.
|
We've confirmed the CI failure was from a build that completed before #6993 was merged in, so I'm now satisfied there's no remaining problem and #6993 fixed it. The 1ms was clearly wrong, as that could be a basically zero delay if the next tick happens as the call is made. 3ms should be fine. @bulislaw - Now do update this file along with everything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pending the new LP ticker HAL changes, we're still seeing test issues on
the NRF51.
On the assumption that the LP ticker PR will fix it, and knowing that it
is currently lacking the necessary change to DEVICE_LPTICKER for this
test, change the test now.
This deactivates the test, and it will be reenabled when the LP ticker
PR lands, rather than being deactivated by it.
Pull request type