Support mbed_start_application for Cortex-M23 #6949

ccli8 · 2018-05-18T09:52:17Z

Description

This PR implements mbed_start_application on Cortex-M23 for bootloader related application.

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

deepikabhavnani

Looks good to me

With "mov r2, #0", compile OK with GCC_ARM, but failed with ARMC6. With "ldr r2, =0", compile OK with ARMC6, but failed with GCC_ARM. Finally, with "movw r2, #0"/"movt r2, #0", compile OK with both ARMC6 and GCC_ARM.

ccli8 · 2018-05-21T09:56:26Z

In 646f614, I fix start_new_application compile error with different toolchains:

With mov r2, #0, compile OK with GCC_ARM, but failed with ARMC6.
With ldr r2, =0, compile OK with ARMC6, but failed with GCC_ARM.
Finally, with movw r2, #0/movt r2, #0, compile OK with both ARMC6 and GCC_ARM.

cmonr · 2018-05-24T03:34:08Z

@dreemkiller Mind taking a look at this? Not sure who else would be familiar with the M23 aside for you and @deepikabhavnani

dreemkiller · 2018-05-24T18:33:36Z

@TacoGrandeTX, take a look

TacoGrandeTX · 2018-05-24T21:29:47Z

platform/mbed_application.c

@@ -48,12 +48,20 @@ static void powerdown_nvic()
    int i;
    int j;

+#if defined(__CORTEX_M23)
+    isr_groups_32 = 16;


16 is not a good number... and more than even a M33 could support. The max number of external interrupts a M23 can support is 240. It's sad that M23 doesn't have the ICTR so the max value we could use here is 7 (or 8... depending on how it's used elsewhere). Rule SGCR in v8-M ARM states: "When a particular NVIC interrupt line is not implemented, the registers that are associated with it are reserved." Yet Rule GLNG states "Privileged accesses to unimplemented registers are RES0" so accessing non-existing registers should be harmless but are wasteful.

@TacoGrandeTX Thanks for your detailed information. I fix it in 3c14cb6.

TacoGrandeTX · 2018-05-24T21:44:53Z

platform/mbed_application.c

@@ -69,17 +77,20 @@ static void powerdown_scb(uint32_t vtor)
    SCB->SCR = 0x00000000;
    // SCB->CCR     - Implementation defined value
    for (i = 0; i < 12; i++) {
-#if defined(__CORTEX_M7)
+#if defined(__CORTEX_M7) || defined(__CORTEX_M23)


Not good - M23 has only 2 SHPR registers (the first is reserved). Looks like we have mixed up the size of our register definitions... core_cm23.h is using uint32_t (x2) while core_cm7.h is using uint8_t (x12). We need two for loops or should change SCB_Type in core_cm23.h.

@TacoGrandeTX I fix it in 3c14cb6.

TacoGrandeTX · 2018-05-24T21:55:41Z

platform/mbed_application.c

@@ -107,7 +118,12 @@ __asm static void start_new_application(void *sp, void *pc)
 void start_new_application(void *sp, void *pc)
 {
    __asm volatile (
+#if defined(__CORTEX_M23)


This two-instruction sequence is not required... "mov r2, #0" will put 0 (zero-extended) into r2 on the M23. We can remove the entire #if block. MOVW/MOVT is useful for loading a full 32-value into a register without a literal pool... not the case here.

Sorry - missed the commit comments! Clearly AC6 is not accepting the inline assembly properly (I ran a local test) so perhaps we could use "movw r2, #0" for both conditions and still remove the #if block.

@TacoGrandeTX I replace with movw/movt and remove #if block in 3c14cb6.

cmonr · 2018-05-25T15:18:05Z

@ccli8 ^^^ ?

cmonr · 2018-05-25T15:50:46Z

Taking another look at this PR, this can come in with a patch release.

1. M23 doesn't support ICTR and supports up to 240 external interrupts. 2. Fix reset of SHPR 3. Fix inline assembly compile error with ARMC6

cmonr · 2018-05-29T16:12:42Z

@TacoGrandeTX @deepikabhavnani Mind re-reviewing?

TacoGrandeTX

MOVT is superfluous - recommend removing it.

TacoGrandeTX · 2018-05-29T22:19:42Z

platform/mbed_application.c

@@ -118,12 +125,8 @@ __asm static void start_new_application(void *sp, void *pc)
 void start_new_application(void *sp, void *pc)
 {
    __asm volatile (
-#if defined(__CORTEX_M23)
-        "movw   r2, #0      \n"
+        "movw   r2, #0      \n" // Fail to compile "mov r2, #0" with ARMC6. Replace with movw/movt.
        "movt   r2, #0      \n"


Sorry - my previous comments weren't very clear! MOVT is superfluous here as MOVW will zero-extend. So we can remove the MOVT instruction. "MOVW r2, #0" will put 0x0 into all 32-bits of r2.

@TacoGrandeTX Yes, MOVT is superfluous. I remove it in 23dcd82.

cmonr · 2018-05-31T22:41:03Z

Looks like all of the review comments have been addressed.
@TacoGrandeTX Mind confirming?

/morph build

mbed-ci · 2018-06-01T04:55:31Z

Build : SUCCESS

Build number : 2215
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6949/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

adbridge · 2018-06-01T10:54:31Z

Restarted pr-head

mbed-ci · 2018-06-02T00:42:49Z

Exporter Build : SUCCESS

Build number : 1842
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6949/

mbed-ci · 2018-06-02T01:45:26Z

Test : FAILURE

Build number : 2011
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6949/2011

cmonr · 2018-06-02T03:05:00Z

Interesting... Don't think the test failure is the PR's fault.
/morph test

mbed-ci · 2018-06-02T09:38:18Z

Test : SUCCESS

Build number : 2015
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6949/2015

cmonr · 2018-06-03T01:41:45Z

@TacoGrandeTX Could you re-approve if you're alright with the changes?

TacoGrandeTX

Good!

cmonr · 2018-06-06T16:58:22Z

/morph build

cmonr · 2018-06-06T16:58:41Z

Oh...
Me and my reflexes.

mbed-ci · 2018-06-06T20:44:13Z

Build : SUCCESS

Build number : 2253
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6949/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-07T02:33:30Z

Test : SUCCESS

Build number : 2042
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6949/2042

mbed-ci · 2018-06-07T05:54:25Z

Exporter Build : SUCCESS

Build number : 1878
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6949/

Support mbed_start_application for Cortex-M23

b3f17a9

0xc0170 requested review from c1728p9 and deepikabhavnani May 18, 2018 10:09

0xc0170 added the needs: review label May 18, 2018

deepikabhavnani previously approved these changes May 18, 2018

View reviewed changes

Fix start_new_application compile error on Cortex-M23

646f614

With "mov r2, #0", compile OK with GCC_ARM, but failed with ARMC6. With "ldr r2, =0", compile OK with ARMC6, but failed with GCC_ARM. Finally, with "movw r2, #0"/"movt r2, #0", compile OK with both ARMC6 and GCC_ARM.

ccli8 dismissed deepikabhavnani’s stale review via 646f614 May 21, 2018 09:51

cmonr added the release-version: 5.9.0-rc1 label May 24, 2018

cmonr requested a review from a team May 24, 2018 03:28

cmonr requested review from dreemkiller and removed request for a team May 24, 2018 16:25

TacoGrandeTX suggested changes May 24, 2018

View reviewed changes

cmonr added the needs: work label May 24, 2018

0xc0170 removed the needs: review label May 25, 2018

adbridge added the risk: R label May 25, 2018

cmonr removed risk: R release-version: 5.9.0-rc1 labels May 25, 2018

Fix mbed_start_application on Cortex-M23

3c14cb6

1. M23 doesn't support ICTR and supports up to 240 external interrupts. 2. Fix reset of SHPR 3. Fix inline assembly compile error with ARMC6

cmonr added needs: review and removed needs: work labels May 29, 2018

TacoGrandeTX reviewed May 29, 2018

View reviewed changes

Remove superfluous MOVT in mbed_start_application/start_new_application

23dcd82

cmonr added the needs: CI label May 31, 2018

cmonr added release-version: 5.8.6 release-version: 5.9.1 and removed needs: review labels May 31, 2018

0xc0170 added needs: review and removed needs: CI labels Jun 4, 2018

adbridge removed the release-version: 5.8.6 label Jun 4, 2018

TacoGrandeTX approved these changes Jun 6, 2018

View reviewed changes

cmonr added the needs: CI label Jun 6, 2018

cmonr approved these changes Jun 6, 2018

View reviewed changes

cmonr removed the needs: review label Jun 6, 2018

0xc0170 approved these changes Jun 7, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Jun 7, 2018

cmonr merged commit 38f9519 into ARMmbed:master Jun 7, 2018

kegilbert removed the ready for merge label Jun 7, 2018

ccli8 deleted the nuvoton_m23_bootloader branch June 8, 2018 02:11

Support mbed_start_application for Cortex-M23 #6949

Support mbed_start_application for Cortex-M23 #6949

Uh oh!

Conversation

ccli8 commented May 18, 2018 • edited by cmonr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

deepikabhavnani left a comment

Choose a reason for hiding this comment

Uh oh!

ccli8 commented May 21, 2018

Uh oh!

cmonr commented May 24, 2018

Uh oh!

dreemkiller commented May 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented May 25, 2018

Uh oh!

cmonr commented May 25, 2018

Uh oh!

cmonr commented May 29, 2018

Uh oh!

TacoGrandeTX left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented May 31, 2018

Uh oh!

mbed-ci commented Jun 1, 2018

Triggering tests

Uh oh!

adbridge commented Jun 1, 2018

Uh oh!

mbed-ci commented Jun 2, 2018

Uh oh!

mbed-ci commented Jun 2, 2018

Uh oh!

cmonr commented Jun 2, 2018

Uh oh!

mbed-ci commented Jun 2, 2018

Uh oh!

cmonr commented Jun 3, 2018

Uh oh!

TacoGrandeTX left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jun 6, 2018

Uh oh!

cmonr commented Jun 6, 2018

Uh oh!

mbed-ci commented Jun 6, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 7, 2018

Uh oh!

mbed-ci commented Jun 7, 2018

Uh oh!

Uh oh!

ccli8 commented May 18, 2018 •

edited by cmonr

Loading