GenericGattClient: Fix discovery termination. #6814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The procedure should be terminated whenever the server returns an error not equal to ATTRIBUTE_NOT_FOUND. The block was effectivelly terminated but the procedure was not. As a result the discovery was operating on already freed memory.
|
@RobMeades Here's my fix for #6806, could you tell if it fixes the issue on your end; I've just tried with the application you attached with your ticket. @donatieng Could you review ? |
|
Yup, confirmed that fixes issue #6806 for me. |
|
/morph build |
Build : SUCCESSBuild number : 1929 Triggering tests/morph test |
Test : SUCCESSBuild number : 1751 |
Exporter Build : SUCCESSBuild number : 1575 |
cmonr
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The procedure should be terminated whenever the server returns an error not equal
to ATTRIBUTE_NOT_FOUND. The block was effectivelly terminated but the
procedure was not. As a result the discovery was operating on already
freed memory.
It should fixes #6806 .
Pull request type