-
Notifications
You must be signed in to change notification settings - Fork 3k
Prevent compiling with unsupported compilers #6540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a few follow up questions/potential tasks:
- Might be a good idea to add a test for
target_supports_toolchain
, specifically for the ARM case. - In the NotSupportedException, do we want to also state that "It is possible to override the supported toolchains in the application configuration and compile with the unsupported toolchain"?
Please review travis CI, failures related |
All of the tests needed to support gcc_arm. |
/morph build |
Build : SUCCESSBuild number : 1666 Triggering tests/morph test |
Test : SUCCESSBuild number : 1461 |
Exporter Build : SUCCESSBuild number : 1300 |
Rerunning since last build is stale, but will be first in queue! /morph build |
Build : SUCCESSBuild number : 1827 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1471 |
Test : FAILUREBuild number : 1633 |
/morph test |
Test : SUCCESSBuild number : 1640 |
Description
Before this change it is possible to compile with a compiler that a
device port does not support. Afterwards it will not be.
It is possible to override the supported toolchains in the application
configuration and compile with the unsupported toolchain after this change.
Resolves #5109
Pull request type
[✓] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change