Nuvoton: Fix us_ticker/lp_ticker #6394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greentea: NUC472/ARMGreentea: NUC472/GCC_ARMGreentea: NUC472/IAR |
Greentea: M453/ARMGreentea: M453/GCC_ARMGreentea: M453/IAR |
Greentea: M487/ARMGreentea: M487/GCC_ARMGreentea: M487/IAR |
Greentea: NANO130/ARMGreentea: NANO130/GCC_ARMGreentea: NANO130/IAR |
|
Out of curiosity, why are these 3 fixes in one commit?
|
@0xc0170 It was to check |
|
@ccli8 So did those three issues need to be fixed all at once to fix the bug, or are these three separate issues, in which only one was needed to fix the bug? |
@cmonr The third one is the major cause for |
|
@ccli8 Thanks for that clarification. Would you mind splitting up your commit into two to deliniate those differences? |
|
@cmonr How about fix the commit message? The |
|
It was not clear how those 3 are related together. I would have guessed based on the list that these could be split. |
…_ticker/lp_ticker
mbed-os-tests-mbed_drivers-lp_ticker/Test multi ticker test fails inconstantly. This commit is mainly to fix the issue.
ccli8
force-pushed
the
nuvoton_fix_ticker
branch
from
a49d36d to
ccec9d7
Compare
0xc0170
approved these changes
Mar 26, 2018
|
/morph build |
Build : SUCCESSBuild number : 1572 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1212 |
Test : SUCCESSBuild number : 1364 |
cmonr
approved these changes
Mar 27, 2018
| @@ -115,10 +115,7 @@ void lp_ticker_set_interrupt(timestamp_t timestamp) | |||
| uint32_t cmp_timer = timestamp * NU_TMRCLK_PER_TICK; | |||
| cmp_timer = NU_CLAMP(cmp_timer, TMR_CMP_MIN, TMR_CMP_MAX); | |||
| timer_base->CMP = cmp_timer; | |||
|
|
|||
| /* NOTE: When engine is clocked by low power clock source (LXT/LIRC), we need to wait for 3 engine clocks. */ | |||
| wait_us((NU_US_PER_SEC / NU_TMRCLK_PER_SEC) * 3); | |||
There was a problem hiding this comment.
Why is this wait still needed? If it's still needed, shouldn't the note/comment still be present?
There was a problem hiding this comment.
@cmonr It was needed, but the wait_us comment was removed inadvertently. In the immediately following commit ccec9d7, all wait_us comments are moved to the front:
/* NOTE: When system clock is higher than timer clock, we need to add 3 engine clock
* (recommended by designer) delay to wait for above timer control to take effect. */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the fixes with us_ticker/lp_ticer:
Pull request type