Skip to content

STM32 RTC : update free function #6217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2018
Merged

STM32 RTC : update free function #6217

merged 2 commits into from
Feb 27, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

Fix found during RTC tests with reset.

Tests status verified in master and in feature-hal-spec-rtc branches

@mprse

Pull request type

  • Fix
  • Refactor
  • New Target
  • Feature

@jeromecoutant jeromecoutant mentioned this pull request Feb 26, 2018
Merged
@mprse
Copy link
Contributor

mprse commented Feb 27, 2018

@jeromecoutant Thanks for this fix.

cmonr
cmonr previously approved these changes Feb 27, 2018
View reviewed changes
@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1269
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6217/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mprse
Copy link
Contributor

mprse commented Feb 27, 2018

@jeromecoutant @cmonr Please note that we have some failures indicated by CI (Jenkins and AWS). Unfortunately I don't have access to check what is wrong.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2018

I'll restart both, reviewed, not related to this PR

0xc0170
0xc0170 reviewed Feb 27, 2018
View reviewed changes
targets/TARGET_STM/rtc_api.c
@@ -144,28 +144,8 @@ void rtc_init(void)

void rtc_free(void)
{
#if !MBED_CONF_TARGET_LSE_AVAILABLE
Copy link
Contributor

@0xc0170 0xc0170 Feb 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find info for this removal in the commit message

Can you provide description how is this being updated? MBED_CONF_TARGET_LSE_AVAILABLE why is being removed, and adding TARGET_STM32F1 - are these 2 related?

Can you amend the commit message?

@jeromecoutant
STM32 RTC : update free function
45cbdc8 
- LSI specific implementation is removed

- Remove RTC clock disable
@jeromecoutant
STM32F1 RTC : Date read after reset
961c8da 
F1 is the only STM32 family where RTC date is not saved into registers
@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Test : SUCCESS

Build number : 1066
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6217/1066

0xc0170
0xc0170 approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing more info, and splitting it to 2 commits

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1277
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6217/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Exporter Build : SUCCESS

Build number : 939
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6217/

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Test : SUCCESS

Build number : 1070
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6217/1070

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Exporter Build : FAILURE

Build number : 943
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6217/

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

Restarting the export build. Another ARM license file issue...

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Exporter Build : SUCCESS

Build number : 950
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6217/

@cmonr cmonr merged commit 19e07e8 into ARMmbed:master Feb 27, 2018
@cmonr cmonr removed the needs: CI label Feb 27, 2018
@jeromecoutant jeromecoutant deleted the PR_RTC branch February 28, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@cmonr cmonr cmonr left review comments

Assignees
No one assigned
Labels
release-version: 5.7.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @mprse @cmonr @mbed-ci @0xc0170