Skip to content

ODIN MTB LEDs Fix #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2018
Merged

ODIN MTB LEDs Fix #6193

merged 1 commit into from
Feb 27, 2018

Conversation

ashok-rao
Copy link
Contributor

@ashok-rao ashok-rao commented Feb 23, 2018

Description

Clean up of Pin names for ODIN MTB. Required to build examples from online compiler.

Pull request type

  • Fix

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2018

@ARMmbed/team-ublox Please review


LED1 = LED_RED,
LED2 = LED_GREEN,
LED3 = LED_BLUE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LED4 not needed? I recall some tests required LED1-4. I can not locate those tests (my searching fails), but most of the platforms defines LED1-4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 , I think LED1, LED2 are mandatory for the tests.. not sure about LED3 & LED4..
@cmonr .. IIRC, you added an LED2 in one of my other PR's for the tests as mandatory.. are LED3 and LED4 also mandatory?

Copy link
Contributor

@0xc0170 0xc0170 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmonr .. IIRC, you added an LED2 in one of my other PR's for the tests as mandatory.. are LED3 and LED4 also mandatory?

I assume not (can't find a reference with this requirement at the moment), wanted to be certain as it was previously LED up to 7, now we reducing to 3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, only LED1 and LED2 are manditory for the tests to run (which now that I'm thinking about it, that should probaly be a bug). All other LED definitions are not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this maybe something to consider for future. @cmonr can you point us to the location(s) where the LED's are used for the tests..My search yielded nothing..

@andreaslarssonublox
Copy link

I have no ODIN MTB to check the LEDs with but otherwise I think it looks OK.

@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 26, 2018

Build : SUCCESS

Build number : 1263
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6193/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 26, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

==========STDERR==========
Eclipse:
An error has occurred. See the log file
/tmp/tmpIm79fN/.metadata/.log.

Eclipse, you and I need to have a word...

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

@cmonr cmonr merged commit 815c6fb into ARMmbed:master Feb 27, 2018
@ashok-rao
Copy link
Contributor Author

Thanks @cmonr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants