-
Notifications
You must be signed in to change notification settings - Fork 3k
ODIN MTB LEDs Fix #6193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODIN MTB LEDs Fix #6193
Conversation
@ARMmbed/team-ublox Please review |
|
||
LED1 = LED_RED, | ||
LED2 = LED_GREEN, | ||
LED3 = LED_BLUE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LED4 not needed? I recall some tests required LED1-4. I can not locate those tests (my searching fails), but most of the platforms defines LED1-4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmonr .. IIRC, you added an LED2 in one of my other PR's for the tests as mandatory.. are LED3 and LED4 also mandatory?
I assume not (can't find a reference with this requirement at the moment), wanted to be certain as it was previously LED up to 7, now we reducing to 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, only LED1 and LED2 are manditory for the tests to run (which now that I'm thinking about it, that should probaly be a bug). All other LED definitions are not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this maybe something to consider for future. @cmonr can you point us to the location(s) where the LED's are used for the tests..My search yielded nothing..
I have no ODIN MTB to check the LEDs with but otherwise I think it looks OK. |
/morph build |
Build : SUCCESSBuild number : 1263 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 928 |
Test : SUCCESSBuild number : 1060 |
Eclipse, you and I need to have a word... /morph export-build |
Exporter Build : SUCCESSBuild number : 930 |
Thanks @cmonr ! |
Description
Clean up of Pin names for ODIN MTB. Required to build examples from online compiler.
Pull request type