Adding MTB ublox NINA-B1 as a new target #5837
Conversation
|
#5838 .. raised for reset over serial. Unless this is fixed, CI will not pass for this PR. Please hold review / CI until then. Thanks. |
|
@0xc0170 .. this PR is now ready for CI .. New DAPLink ARMmbed/DAPLink#376 fixes the issue #5838 |
|
@ashok-rao Can you provide tests results here (to know how target was tested) |
|
/morph build |
| "uart_hwfc": 0 | ||
| }, | ||
| "config": { | ||
| "usb_tx": { |
There was a problem hiding this comment.
this was refactored, the names are now stdio_serial or similar, please update
|
Thanks @0xc0170 . Attaching GCC, Greentea log below. Would you like me to check with IAR and ARMCC also? |
Build : SUCCESSBuild number : 966 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 653 |
Test : SUCCESSBuild number : 794 |
Yes , please |
| @@ -0,0 +1,139 @@ | |||
| #ifndef MBED_PINNAMES_H | |||
There was a problem hiding this comment.
can you add license header file please here on the top?
There was a problem hiding this comment.
@0xc0170 .. Thanks. Done!
|
@ashok-rao Can you share tests results please here? I left one comment to address license header missing from one file |
|
Thanks @0xc0170 ..yes, just saw your comments. Will update ASAP! |
|
@0xc0170 .. Attaching GT logs: |
|
/morph build |
Build : SUCCESSBuild number : 990 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 684 |
Test : SUCCESSBuild number : 812 |
|
@0xc0170 ..Thank you. Will this be released in 5.7.4 ? |
It's currently being released, 5.7.5 will be in 2 weeks (this will go there) |
Description
Adding ublox NINA B1 as a new target.
Status
IN DEVELOPMENT
Todos
Deploy notes
Needs addition of new HW in CI.
cc @screamerbg @chris-styles @studavekar