Skip to content

mem_trace tests refactoring #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

mem_trace tests refactoring #5673

merged 1 commit into from
Jan 4, 2018

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Dec 7, 2017 •
edited
Loading

Description

  • tests refactoring and align to coding standards
  • multithreaded test added

Status

HOLD

Migrations

NO

Related PRs

Requires following PR :
#5614

@maciejbocianski
Copy link
Contributor Author

@bulislaw @0xc0170

@0xc0170 0xc0170 requested a review from bulislaw December 11, 2017 08:32
@bulislaw
Copy link
Member

@jamesbeyond please review

jamesbeyond
jamesbeyond reviewed Dec 19, 2017
View reviewed changes
TESTS/mbed_drivers/mem_trace/main.cpp
check_malloc_op(pmem ++, p_calloc, nmemb * size);
check_calloc_op(pmem ++, p_calloc, nmemb, size);
check_free_op(pmem ++, p_realloc);
check_sanity(num_op);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last version, the argument to check_sanity() was 6, now changed to 5, is this something expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was 6 because calloc was traced twice as calloc + malloc
I was even worse when heap stats was enabled but this is fixed by #5614

jamesbeyond
jamesbeyond approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2017

Build : SUCCESS

Build number : 730
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5673/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2017

Exporter Build : FAILURE

Build number : 382
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5673/

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2017

Test : FAILURE

Build number : 558
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5673/558

@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Dec 20, 2017 •
edited
Loading

Failing on:

tests-netsocket-gethostbyname
[1513791143.37][HTST][INF] host test setup() call... 
[1513791143.37][HTST][INF] CALLBACKs updated 
[1513791143.37][HTST][INF] host test detected: default_auto 
[1513791145.08][CONN][RXD] Thread 00000000 error -4: Parameter error 
[1513791264.20][HTST][INF] test suite run finished after 120.83 sec...

@0xc0170 this test require #5614 to be merged first
other point, this test will not be run on CI since it require MBED_MEM_TRACING_ENABLED flag to be set

@adbridge
Copy link
Contributor

/morph build

@adbridge
Copy link
Contributor

@bulislaw are you happy with these changes? If so , please approve

@mbed-ci
Copy link

mbed-ci commented Dec 29, 2017

Build : SUCCESS

Build number : 768
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5673/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 29, 2017

Exporter Build : SUCCESS

Build number : 423
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5673/

@mbed-ci
Copy link

mbed-ci commented Dec 29, 2017

Test : SUCCESS

Build number : 608
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5673/608

@theotherjimmy theotherjimmy merged commit b12d0fb into ARMmbed:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
release-version: 5.7.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maciejbocianski @bulislaw @0xc0170 @mbed-ci @adbridge @jamesbeyond @theotherjimmy