Skip to content

STM32: Fix CAN3 #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2017
Merged

STM32: Fix CAN3 #5667

merged 4 commits into from
Dec 12, 2017

Conversation

adamheinrich
Copy link
Contributor

@adamheinrich adamheinrich commented Dec 6, 2017

This fixes CAN3 for STM32 platforms. Checked with two NUCLEO-F413ZH boards (added in #5608).

I was not able to receive any data on STM32F413ZH. It was because the filter number 14 is not in the valid range for CAN3.

This restriction also holds for STM32F767ZI (checked in both RM0430 for STM32F413 and RM0410 for STM32F767), which has been originally used to test CAN3 in #5486.

Also, this PR sets correct indexes for interrupt handlers.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 7, 2017

@ARMmbed/team-st-mcd Please review

@bcostm
Copy link
Contributor

bcostm commented Dec 7, 2017

Thanks for the fix.

I have copied your changes in PR #5674.

@adamheinrich
Copy link
Contributor Author

adamheinrich commented Dec 7, 2017

@bcostm Thank you for the CAN_NUM test which solves #5668. Is there any reason to duplicate the PR? I have cherry-picked your commits here as well :)

bcostm and others added 3 commits December 7, 2017 18:04
CAN_2 and CAN_3 are enum and not #define and this causes compilation error with GCC_ARM

Instead put back the test of CAN_NUM (which are defined in can_device.h).
Filter numbers 14 to 27 are reserved for dual CAN configuration.
However, CAN3 operates in single CAN configuration according to the
reference manual).
Copy link
Contributor

@bcostm bcostm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have closed my PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 8, 2017

Build : SUCCESS

Build number : 669
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5667/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 8, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2017

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 8, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2017

/morph test

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants