STM32: Fix CAN3 #5667
Merged
STM32: Fix CAN3 #5667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamheinrich
force-pushed
the
fix-stm32-can3
branch
from
f525d5f to
9e0781d
Compare
|
@ARMmbed/team-st-mcd Please review |
|
Thanks for the fix. I have copied your changes in PR #5674. |
CAN_2 and CAN_3 are enum and not #define and this causes compilation error with GCC_ARM Instead put back the test of CAN_NUM (which are defined in can_device.h).
Filter numbers 14 to 27 are reserved for dual CAN configuration. However, CAN3 operates in single CAN configuration according to the reference manual).
adamheinrich
force-pushed
the
fix-stm32-can3
branch
from
9e0781d to
f08c04d
Compare
bcostm
approved these changes
Dec 8, 2017
|
/morph build |
Build : SUCCESSBuild number : 669 Triggering tests/morph test |
Exporter Build : ABORTEDBuild number : 312 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 316 |
|
/morph test |
Test : SUCCESSBuild number : 498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CAN3 for STM32 platforms. Checked with two NUCLEO-F413ZH boards (added in #5608).
I was not able to receive any data on STM32F413ZH. It was because the filter number 14 is not in the valid range for CAN3.
This restriction also holds for STM32F767ZI (checked in both RM0430 for STM32F413 and RM0410 for STM32F767), which has been originally used to test CAN3 in #5486.
Also, this PR sets correct indexes for interrupt handlers.