-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32: Fix CAN3 #5667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32: Fix CAN3 #5667
Conversation
f525d5f
to
9e0781d
Compare
@ARMmbed/team-st-mcd Please review |
Thanks for the fix. I have copied your changes in PR #5674. |
CAN_2 and CAN_3 are enum and not #define and this causes compilation error with GCC_ARM Instead put back the test of CAN_NUM (which are defined in can_device.h).
Filter numbers 14 to 27 are reserved for dual CAN configuration. However, CAN3 operates in single CAN configuration according to the reference manual).
9e0781d
to
f08c04d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have closed my PR.
/morph build |
Build : SUCCESSBuild number : 669 Triggering tests/morph test |
Exporter Build : ABORTEDBuild number : 312 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 316 |
/morph test |
Test : SUCCESSBuild number : 498 |
This fixes CAN3 for STM32 platforms. Checked with two NUCLEO-F413ZH boards (added in #5608).
I was not able to receive any data on STM32F413ZH. It was because the filter number 14 is not in the valid range for CAN3.
This restriction also holds for STM32F767ZI (checked in both RM0430 for STM32F413 and RM0410 for STM32F767), which has been originally used to test CAN3 in #5486.
Also, this PR sets correct indexes for interrupt handlers.