Fix fatal parameter error when deleting/terminating Thread object #5587

marogi · 2017-11-25T17:45:28Z

Description

Call to osThreadTerminate is guarded by local_id != 0 check, to avoid parameter error fault when deleting or terminating Thread object that was not started.

Status

READY

Migrations

NO

Todos

Tests

Steps to test or reproduce

On any target (tested with FRDM-K64F):

#include "mbed.h"

RawSerial output(USBTX, USBRX);

int main(int argc, char **argv)
{
    output.baud(115200);

    output.printf("\r\nStarting mbed\r\n");

    {
        rtos::Thread dummyToTriggerError(osPriorityNormal, 0x500);
    }

    while(1);
}

output:

Starting mbed
Thread 0x0 error -4: Parameter error

Call to osThreadTerminate is guarded by local_id check, to avoid parameter error fault when deleting or terminating Thread object that was not started.

0xc0170 · 2017-11-27T08:19:03Z

rtos/Thread.cpp

-        ret = osThreadTerminate(local_id);
+        // if local_id == 0 Thread was not started in first place
+        // and does not have to be terminated
+        if(local_id != 0) {


if () - please leave as space there

0xc0170 · 2017-11-27T08:21:35Z

@marogi Can you please sign https://os.mbed.com/contributor_agreement/?

marogi · 2017-11-27T08:56:43Z

Sure - whitespace fixed.

@ Contributor agreement: I have it signed on my mbed accout (devmarogi, linked to this GitHub account). Any other way I need to sign it?

bulislaw

LGTM

0xc0170 · 2017-11-27T11:50:11Z

/morph build

0xc0170 · 2017-11-27T11:50:39Z

@marogi 👍 for the fix

mbed-ci · 2017-11-27T12:18:17Z

Build : SUCCESS

Build number : 598
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5587/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-27T13:38:26Z

Exporter Build : SUCCESS

Build number : 210
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5587/

mbed-ci · 2017-11-27T14:38:46Z

Test : FAILURE

Build number : 411
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5587/411

0xc0170 · 2017-11-27T14:39:53Z

Seems like device problem ,will restart once fixed, going to investigate

theotherjimmy · 2017-11-27T16:32:51Z

/morph uvisor-test

kegilbert · 2017-11-27T16:41:30Z

@0xc0170 Updated some of the CI hardware to hopefully resolve the F429ZI flash errors. I'll rekick this off ASAP.

0xc0170 · 2017-11-27T16:42:18Z

@marogi - can you or slashdevteam sign to travis-ci, it does not recognize you, and labels this PR as abuse.

marogi · 2017-11-27T16:57:09Z

@0xc0170 : This fix is really not abuse :)

I saw the abuse status on travis-ci, but once I logged in (via GitHub) it was gone. Is there some other way I can authenticate me/slashdev?

kegilbert · 2017-11-27T17:46:44Z

/morph test

mbed-ci · 2017-11-28T01:23:19Z

Test : SUCCESS

Build number : 423
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5587/423

marogi · 2017-11-28T10:17:24Z

I contacted travis-ci and apparently pull requests from GitHub accounts that never logged into travis-ci will get blocked. They also recommended closing and reopening pull request.

I connected my account to travis-ci, so @0xc0170 could you try to close & reopen this PR?

0xc0170 · 2017-11-28T10:52:20Z

Still flagged as abuse 😭 New PR might resolve it? Thanks @marogi for the logging in.

marogi · 2017-11-28T11:01:09Z

@0xc0170 no problem.

I reported this to travis-ci and will work with them on solution.

mbed-ci · 2017-11-28T11:16:03Z

Build : SUCCESS

Build number : 609
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5587/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-28T12:18:03Z

Test : SUCCESS

Build number : 430
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5587/430

mbed-ci · 2017-11-28T12:18:27Z

Exporter Build : SUCCESS

Build number : 224
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5587/

mbed-ci · 2017-11-28T13:11:04Z

Exporter Build : FAILURE

Build number : 225
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5587/

0xc0170 · 2017-11-30T17:05:53Z

@marogi Have you received any response from travis-ci ? I can help to cherry-pick this change and send a new PR for now, let me know please

marogi · 2017-11-30T17:09:02Z

I'm waiting on one more reply from travis-ci. If it doesn't come tomorrow (or does not solve the issue) I will close this PR and create new one from a different fork (my own, not under slashdevteam).

marogi · 2017-12-01T14:13:40Z

Ok, can we make last one try? This time all settings should make travis-ci happy.

0xc0170 · 2017-12-08T11:43:47Z

Travis works !

mbed-ci · 2017-12-08T13:04:41Z

Build : SUCCESS

Build number : 672
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5587/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-12-08T14:43:24Z

Exporter Build : SUCCESS

Build number : 314
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5587/

mbed-ci · 2017-12-08T14:43:24Z

Exporter Build : SUCCESS

Build number : 314
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5587/

kegilbert · 2017-12-08T17:07:49Z

/morph test

mbed-ci · 2017-12-08T18:49:59Z

Test : SUCCESS

Build number : 496
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5587/496

Fatal parameter error when deleting/terminating Thread object

c721ed8

Call to osThreadTerminate is guarded by local_id check, to avoid parameter error fault when deleting or terminating Thread object that was not started.

0xc0170 requested review from bulislaw and c1728p9 November 27, 2017 08:17

0xc0170 reviewed Nov 27, 2017

View reviewed changes

0xc0170 added the needs: work label Nov 27, 2017

Fixed whitespace

c08e0f5

bulislaw approved these changes Nov 27, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Nov 27, 2017

0xc0170 approved these changes Nov 27, 2017

View reviewed changes

0xc0170 closed this Nov 28, 2017

0xc0170 removed the needs: CI label Nov 28, 2017

0xc0170 reopened this Nov 28, 2017

0xc0170 closed this Dec 8, 2017

0xc0170 reopened this Dec 8, 2017

kjbracey mentioned this pull request Dec 12, 2017

mbed os crash on connecting ethernet adapter connect K64 #5680

Closed

c1728p9 approved these changes Dec 13, 2017

View reviewed changes

0xc0170 added the ready for merge label Dec 13, 2017

SeppoTakalo mentioned this pull request Dec 18, 2017

Upgrade Silicon Labs radio driver to v2.1.1 #5579

Merged

0xc0170 added the release-version: 5.7.1 label Dec 20, 2017

0xc0170 merged commit 6776cb7 into ARMmbed:master Dec 20, 2017

0xc0170 removed the ready for merge label Dec 20, 2017

Fix fatal parameter error when deleting/terminating Thread object #5587

Fix fatal parameter error when deleting/terminating Thread object #5587

Uh oh!

Conversation

marogi commented Nov 25, 2017

Description

Status

Migrations

Todos

Steps to test or reproduce

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 27, 2017

Uh oh!

marogi commented Nov 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 27, 2017

Uh oh!

0xc0170 commented Nov 27, 2017

Uh oh!

mbed-ci commented Nov 27, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 27, 2017

Uh oh!

mbed-ci commented Nov 27, 2017

Uh oh!

0xc0170 commented Nov 27, 2017

Uh oh!

theotherjimmy commented Nov 27, 2017

Uh oh!

kegilbert commented Nov 27, 2017

Uh oh!

0xc0170 commented Nov 27, 2017

Uh oh!

marogi commented Nov 27, 2017

Uh oh!

kegilbert commented Nov 27, 2017

Uh oh!

mbed-ci commented Nov 28, 2017

Uh oh!

marogi commented Nov 28, 2017

Uh oh!

0xc0170 commented Nov 28, 2017

Uh oh!

marogi commented Nov 28, 2017

Uh oh!

mbed-ci commented Nov 28, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 28, 2017

Uh oh!

mbed-ci commented Nov 28, 2017

Uh oh!

mbed-ci commented Nov 28, 2017

Uh oh!

0xc0170 commented Nov 30, 2017

Uh oh!

marogi commented Nov 30, 2017

Uh oh!

marogi commented Dec 1, 2017

Uh oh!

0xc0170 commented Dec 8, 2017

Uh oh!

mbed-ci commented Dec 8, 2017

Triggering tests

Uh oh!

mbed-ci commented Dec 8, 2017

Uh oh!

mbed-ci commented Dec 8, 2017

Uh oh!

kegilbert commented Dec 8, 2017

Uh oh!

mbed-ci commented Dec 8, 2017

Uh oh!

marogi commented Nov 27, 2017 •

edited

Loading