Skip to content

heap_and_stack test refactoring #5483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Nov 13, 2017

Description

Test refactoring and alignment to coding standards
Added test for main stack

Status

READY

Migrations

NO

@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Nov 13, 2017

@bulislaw @0xc0170 @c1728p9
What do you think about memory layout test?
Maybe we should create separate test suite for memory layout?

@maciejbocianski maciejbocianski force-pushed the heap_and_stack_tests branch 2 times, most recently from 417c0ed to b444b70 Compare November 14, 2017 12:40
@maciejbocianski
Copy link
Contributor Author

After discussion with @bulislaw we decided to remove memory layout test and take care of it later

@bulislaw
Copy link
Member

Yes, it's not good enough reason for us to ask partners (or do it ourselves) to update linker script for every platform for every compiler.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2017

@maciejbocianski Feel free to close this. Not sure if good enough reason for an issue , as this can be turned into an issue to capture all problems you found with this patch.

@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Nov 17, 2017

@0xc0170 The problematic part of the test was removed.
Rest of the test is OK and ready to go
Please remove "do not merge" label

@bulislaw
Copy link
Member

bulislaw commented Nov 17, 2017

Lets ignore the memory layout tests for now, I'm not sure there's good enough reason to mandate that for existing platforms. At least the ones that are failing.

@maciejbocianski
Copy link
Contributor Author

TODO comment added : add memory layout test.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2017

Build : SUCCESS

Build number : 559
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5483/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

@maciejbocianski
Copy link
Contributor Author

@0xc0170
Fail is not connected to heap_and_stack test
Failing test: tests-netsocket-gethostbyname
Failing device: NUCLEO_F746ZG-IAR

[1511246558.84][HTST][INF] host test detected: default_auto 
[1511246620.47][CONN][RXD] :48::FAIL: Expected 0 Was -3010 
[1511246620.55][CONN][RXD] >>> failure with reason 'Assertion Failed' during 'Test Setup Handler'

@bulislaw
Copy link
Member

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

Build : SUCCESS

Build number : 563
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5483/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2017

An error has occurred. See the log file
/tmp/tmplo9Q1N/.metadata/.log.

SUCCESS
FAILURE

I can not see the failure and success at the same time. @maciejbocianski CAn you look at the log if you spot any error, its just one board and example blinky (not related but might be bug somewhere).

Retriggering at least once

/morph export-build

@maciejbocianski
Copy link
Contributor Author

Don't know how to access log.
The error looks like totally not connected to this PR

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants