-
Notifications
You must be signed in to change notification settings - Fork 3k
heap_and_stack test refactoring #5483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heap_and_stack test refactoring #5483
Conversation
417c0ed
to
b444b70
Compare
After discussion with @bulislaw we decided to remove memory layout test and take care of it later |
Yes, it's not good enough reason for us to ask partners (or do it ourselves) to update linker script for every platform for every compiler. |
@maciejbocianski Feel free to close this. Not sure if good enough reason for an issue , as this can be turned into an issue to capture all problems you found with this patch. |
@0xc0170 The problematic part of the test was removed. |
Lets ignore the memory layout tests for now, I'm not sure there's good enough reason to mandate that for existing platforms. At least the ones that are failing. |
b444b70
to
bc10335
Compare
TODO comment added : |
/morph build |
Build : SUCCESSBuild number : 559 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 172 |
Test : FAILUREBuild number : 377 |
@0xc0170
|
/morph build |
Build : SUCCESSBuild number : 563 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 176 |
Test : SUCCESSBuild number : 378 |
SUCCESS I can not see the failure and success at the same time. @maciejbocianski CAn you look at the log if you spot any error, its just one board and example blinky (not related but might be bug somewhere). Retriggering at least once /morph export-build |
Don't know how to access log. |
Exporter Build : SUCCESSBuild number : 177 |
Description
Test refactoring and alignment to coding standards
Added test for main stack
Status
READY
Migrations
NO