-
Notifications
You must be signed in to change notification settings - Fork 3k
DISCO_L072CZ_LRWAN1: HSE clock configuration improvement #5482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this addressing the clock drift (the calibration done?) ? I can see it done now with this patch. |
No this is not related to HSI calibration. The CRS (Clock Recovery System) is for the HSI48 clock used by USB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One nit:
//HAL_RCC_MCOConfig(RCC_MCO1, RCC_MCO1SOURCE_HSE, RCC_MCODIV_2); // 4 MHz
this is deadcode and should be removed? If needed, it can be found in the drivers/app notes , somewhere, not here.
/morph build |
Build : SUCCESSBuild number : 514 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 129 |
OK. I have removed the dead code in the last commit. |
/morph build |
Build : SUCCESSBuild number : 520 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 134 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 135 |
Test : SUCCESSBuild number : 325 |
Description
Status
READY
Migrations
NO