Skip to content

DISCO_L072CZ_LRWAN1: HSE clock configuration improvement #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2017

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Nov 13, 2017

Description

  • Align the SetSysClock_PLL_HSE function with SetSysClock_PLL_HSI
  • Minor change concerning the MCO pin output used for debug
  • Add a comment in target.json for the HSE clock configuration

Status

READY

Migrations

NO

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 13, 2017

Is this addressing the clock drift (the calibration done?) ? I can see it done now with this patch.

@bcostm
Copy link
Contributor Author

bcostm commented Nov 13, 2017

No this is not related to HSI calibration. The CRS (Clock Recovery System) is for the HSI48 clock used by USB.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One nit:

//HAL_RCC_MCOConfig(RCC_MCO1, RCC_MCO1SOURCE_HSE, RCC_MCODIV_2); // 4 MHz

this is deadcode and should be removed? If needed, it can be found in the drivers/app notes , somewhere, not here.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 14, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2017

Build : SUCCESS

Build number : 514
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5482/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2017

@bcostm
Copy link
Contributor Author

bcostm commented Nov 15, 2017

OK. I have removed the dead code in the last commit.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2017

Build : SUCCESS

Build number : 520
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5482/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2017

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2017

@0xc0170 0xc0170 merged commit 01bc434 into ARMmbed:master Nov 16, 2017
@bcostm bcostm deleted the fix_disco_l072cz_extclock branch November 23, 2017 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants