Skip to content

LPC546XX: Add ENET support #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

LPC546XX: Add ENET support #5433

wants to merge 2 commits into from

Conversation

mmahadevan108
Copy link
Contributor

No description provided.

@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @maclobdell

@mmahadevan108
Copy link
Contributor Author

cc @gorazdko

0xc0170
0xc0170 approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but would like someone from networking team to review

@SeppoTakalo
Copy link
Contributor

@mikaleppanen Can you review this?

We don't have the actual board in CI so I cannot really verify its performance or correctness. I'm fine if its building.

@SeppoTakalo
Copy link
Contributor

Also, there are conflicting files. Please rebase this on top of master so build can be tested against it.

@mmahadevan108
LPC546XX: Add ENET support
4dab604 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@mmahadevan108
Copy link
Contributor Author

Rebased to the current top of master

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2017

/morph build

@0xc0170 0xc0170 requested a review from mikaleppanen November 10, 2017 13:14
@mbed-ci
Copy link

mbed-ci commented Nov 10, 2017

Build : FAILURE

Build number : 491
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5433/

@gorazdko
Copy link
Contributor

gorazdko commented Nov 10, 2017 •
edited
Loading

You can disable "LWIP" feature at FF_LPC546XX for the CI to work:

"target.features_remove": ["LWIP"]

@mmahadevan108
FF_LPC546XX: Remove LWIP feature
898e528 
Signed-off-by: Mahadevan Mahesh <[email protected]>
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2017

You can disable "LWIP" feature at FF_LPC546XX for the CI to work

Can you elaborate? As this is enet support, not yet complete lwip enablement also?

@gorazdko
Copy link
Contributor

Sometime later i will move the fsl_phy.c/h one folder back and add LAN8720 support to reuse it for our board.

Tested mbed-os-example-sockets. ACK

@gorazdko
Copy link
Contributor

@0xc0170 fsl_phy.c/.h is in folder TARGET_LPCXpresso which i removed

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 14, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2017

Build : SUCCESS

Build number : 512
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5433/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2017

Exporter Build : SUCCESS

Build number : 127
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5433/

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2017

Test : SUCCESS

Build number : 331
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5433/331

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2017

I emailed @mmahadevan108 to resolve travis waiting status, I hope we can do it this time 💯

@0xc0170 0xc0170 closed this Nov 16, 2017
@0xc0170 0xc0170 removed the needs: CI label Nov 16, 2017
@maclobdell
Copy link
Contributor

@0xc0170 was this closed intentionally - can you provide a reason here?

@0xc0170 0xc0170 reopened this Nov 28, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2017

@0xc0170 was this closed intentionally - can you provide a reason here?

Travis abuse, I emailed private @mmahadevan108 , and he talked to travis team . haven't heard back thus was not reopened. I'll talk to him again to get further or we can cherrypick this to move forward asap.

@mbed-ci
Copy link

mbed-ci commented Nov 28, 2017

Build : SUCCESS

Build number : 613
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5433/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 28, 2017

Test : SUCCESS

Build number : 433
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5433/433

@0xc0170 0xc0170 mentioned this pull request Nov 28, 2017
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2017

Provided a replacement, that should pass all CI. See the reference above.

@0xc0170 0xc0170 closed this Nov 28, 2017
@0xc0170 0xc0170 removed the needs: CI label Nov 28, 2017
@mbed-ci
Copy link

mbed-ci commented Nov 28, 2017

Exporter Build : ABORTED

Build number : 228
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5433/

@kegilbert
Copy link
Contributor

Saw some previous timeouts, previous build seems solid so rekicking this one off.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 28, 2017

Exporter Build : SUCCESS

Build number : 230
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5433/

@mmahadevan108 mmahadevan108 deleted the LPC546XX_Enet branch May 3, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mmahadevan108 @SeppoTakalo @0xc0170 @mbed-ci @gorazdko @studavekar @maclobdell @kegilbert @mikaleppanen @theotherjimmy