Fix SmartCard HAL on STM32 BluePill board. #5303
Conversation
| @@ -530,8 +529,7 @@ HAL_StatusTypeDef HAL_SMARTCARD_Receive(SMARTCARD_HandleTypeDef *hsc, uint8_t *p | |||
| { | |||
| return HAL_TIMEOUT; | |||
| } | |||
| tmp = (uint16_t*) pData; | |||
| *tmp = (uint8_t)(hsc->Instance->DR & (uint8_t)0xFF); | |||
| *pData = (uint8_t)(hsc->Instance->DR & (uint8_t)0xFF); | |||
There was a problem hiding this comment.
this is changing hal directly, will this be overwritten by next hal update?
There was a problem hiding this comment.
Internal ticket reference : 39116
There was a problem hiding this comment.
Internal ticket reference : 39116
What does this mean, that will be fixed in the next update. What about this change, +1 from your side?
There was a problem hiding this comment.
This means that this part of change is being reviewed internally. But from review the change makes sense so I think we can accept this change in a first step and we will update it later if needed.
There was a problem hiding this comment.
Hi
Just received confirmation from driver team that patch in stm32f1xx_hal_smartcard.c is needed.
Thx for issue reporting
|
@balika011 Can you please sign https://os.mbed.com/contributor_agreement/ ? I could not locate your nick on https://os.mbed.com page |
|
Done. |
|
@jeromecoutant Happy with this patch to go in? |
| @@ -10630,6 +10630,24 @@ typedef struct | |||
| * @} | |||
| */ | |||
|
|
|||
| #define SC_USART USART3 | |||
There was a problem hiding this comment.
I would prefer that this change coming from MSP layer do not end in device/ directory.
Those files are application layer dependent as other application may want other pins than PB_10 / PB_11. So I think that you should rather add them to your project only
| @@ -0,0 +1,127 @@ | |||
| /** | |||
There was a problem hiding this comment.
Same here - if really needed this file stm32f1xx_hal_msp.c belongs to application layer.
| @@ -530,8 +529,7 @@ HAL_StatusTypeDef HAL_SMARTCARD_Receive(SMARTCARD_HandleTypeDef *hsc, uint8_t *p | |||
| { | |||
| return HAL_TIMEOUT; | |||
| } | |||
| tmp = (uint16_t*) pData; | |||
| *tmp = (uint8_t)(hsc->Instance->DR & (uint8_t)0xFF); | |||
| *pData = (uint8_t)(hsc->Instance->DR & (uint8_t)0xFF); | |||
There was a problem hiding this comment.
This means that this part of change is being reviewed internally. But from review the change makes sense so I think we can accept this change in a first step and we will update it later if needed.
|
@balika011 Could you address @LMESTM's comments? |
|
@balika011 BTW, sorry for sending my feedback so late ... I hope you're ok to do the proposed changes. And thanks a lot for reporting and fixing the HAL issue ! |
|
@balika011 Do you need any assistance for the proposed changes? @LMESTM When the HAL receives these fixes? Shall we fix this separately to move forward this proposal? |
|
@0xc0170 Sure - will do so in coming days ... |
|
@balika011 Please review #5505 , will close this one |
Description
The current HAL_SMARTCARD_Receive function corrupts the memory. Changes pData[Size] to 0. That's outside of the pData. Also the MSP is missing and that's needed for smartcard hal to work.
Status
READY