Add support for RedBear's BLE Nano 2 #5231
Conversation
|
The original version of this modified the serial code for flow control, but they aren't necessary anymore with the uart flow control option in targets.json |
|
cc @Cheong2K |
ghost
mentioned this pull request
|
Have you contacted Redbear about this addition? This PR requires a rebase on top of latest master to resolve circle ci failure. |
|
They are the ones who originally wrote it as per the link. All I did was trim out the Blend 2, since I don't have one to test with, and get rid of a hack in the serial api. I was just hoping this might spur some action on their part. |
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Why so many newlines?
There was a problem hiding this comment.
the newlines are the same in https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_DELTA_DFBM_NQ620/device.h and https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_NRF52_DK/device.h and . I guess those should be fixed too at some point. I assume this one was copied from the NRF52 DK.
targets/targets.json
Outdated
| "RBLAB_BLENANO2": { | ||
| "supported_form_factors": ["ARDUINO"], | ||
| "inherits": ["MCU_NRF52"], | ||
| "progen": {"target": "rblab_blenano2"}, |
There was a problem hiding this comment.
"progen" is not an allowed key. Please remove it.
|
rebased with suggested changes. |
|
@theotherjimmy review pls |
|
@theotherjimmy could you please re-review? |
targets/targets.json
Outdated
| "RBLAB_BLENANO2": { | ||
| "supported_form_factors": ["ARDUINO"], | ||
| "inherits": ["MCU_NRF52"], | ||
| "macros_add": ["BOARD_PCA10040", "NRF52_PAN_12", "NRF52_PAN_15", "NRF52_PAN_58", "NRF52_PAN_55", "NRF52_PAN_54", "NRF52_PAN_31", "NRF52_PAN_30", "NRF52_PAN_51", "NRF52_PAN_36", "NRF52_PAN_53", "S132", "CONFIG_GPIO_AS_PINRESET", "BLE_STACK_SUPPORT_REQD", "SWI_DISABLE0", "NRF52_PAN_20", "NRF52_PAN_64", "NRF52_PAN_62", "NRF52_PAN_63", "RBLAB_BLENANO2"], |
There was a problem hiding this comment.
It does not look like you need the "RBLAB_BLENANO2" Macro.
There was a problem hiding this comment.
shouldn't it actually be in extra_labels_add then? that'd seem to match up with other targets now that i look again.
There was a problem hiding this comment.
It should probably be in neither. Adding it to extra_labels_add will do nothing, as the label RBLAB_BLENANO2 is already there as it's the target.
Cribbed from redbear@4bf42f2 I'm not sure if if there are any copyright issues here with what is effectively a set of config files. A few folks have been bugging me (and the redbear folks) for these changes, so I wanted them somewhere centralized.
|
/morph build |
Build : SUCCESSBuild number : 423 Triggering tests/morph test |
Test : SUCCESSBuild number : 215 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 87 |
|
/morph uvisor-test |
|
@alzix Please restart uvisor for this PR |
theotherjimmy
added
ready for merge
release-version: 5.6.5
and removed
ready for merge
labels
Cribbed from redbear@4bf42f2
I'm not sure if if there are any copyright issues here with what is
effectively a set of config files. A few folks have been bugging me (and
the redbear folks) for these changes, so I wanted them somewhere
centralized.