Fix analogin scaling for EFM32 target #5223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @stevew817 @akselsm |
|
|
Fixes ARMmbed#5115. `analogin_read_u16` returns a value in the range `0x0000 - 0xFFF0` since the resolution of the ADC is 12 bits. However, in `analogin_read` this value gets divided by `0xFFFF` assuming the range is `0x0000-0xFFFF`. This causes a small error in the value returned by `AnalogIn::read` for the EFM32 target.
bump |
0xc0170
approved these changes
Oct 10, 2017
|
Approved. |
|
/morph test |
Build : SUCCESSBuild number : 104 Triggering tests/test mbed-os |
Test : SUCCESSBuild number : 48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5115.
analogin_read_u16returns a value in the range0x0000 - 0xFFF0since the resolution of the ADC is 12 bits. However, in
analogin_readthis value gets divided by0xFFFFassuming the rangeis
0x0000-0xFFFF. This causes a small error in the value returned byAnalogIn::readfor the EFM32 target.