Skip to content

Extends test set for EventFlags class #5081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2017
Merged

Extends test set for EventFlags class #5081

merged 1 commit into from
Oct 20, 2017

Conversation

maciejbocianski
Copy link
Contributor

Description

New test suite for EventFlags class

Status

READY

@theotherjimmy
Copy link
Contributor

@0xc0170 Could you take a look?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

cc @deepikabhavnani @bulislaw @c1728p9 @geky @pan-

@maciejbocianski maciejbocianski force-pushed the events_flags_tests branch 2 times, most recently from 934a821 to 8f1ee89 Compare October 2, 2017 08:53
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2017

@maciejbocianski Can you please rebase to resolve circle-ci failure? We will then trigger the Ci test

@theotherjimmy
Copy link
Contributor

@maciejbocianski @0xc0170 I turned off circle CI. It was just a bad copy of travis CI. You may need to push a commit to re-trigger CI and get the red x off of your commit.

@maciejbocianski
Copy link
Contributor Author

done

@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 3, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2017

@maciejbocianski When you do any change, it is beneficial to share how it was tested (how mnay toolchains, targets).

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2017

/morph test-nightly

@mbed-bot
Copy link

mbed-bot commented Oct 4, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1520

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2017

@maciejbocianski PLease look at the results, there are failures related

@maciejbocianski
Copy link
Contributor Author

@0xc0170 fix added

@maciejbocianski maciejbocianski force-pushed the events_flags_tests branch 2 times, most recently from 87faf22 to cd468fb Compare October 5, 2017 14:33
@theotherjimmy
Copy link
Contributor

retest uvisior

@theotherjimmy
Copy link
Contributor

retest uvisor

@maciejbocianski maciejbocianski force-pushed the events_flags_tests branch 4 times, most recently from 145d066 to 99867c1 Compare October 9, 2017 05:20
@theotherjimmy
Copy link
Contributor

@c1728p9 Could you take a look at the new version?

c1728p9
c1728p9 reviewed Oct 9, 2017
View reviewed changes
TESTS/mbedmicro-rtos-mbed/event_flags/main.cpp Outdated

#if defined(MBED_RTOS_SINGLE_THREAD)
#error [NOT_SUPPORTED] test not supported
#endif

#define TEST_STACK_SIZE 512
#define THREAD_STACK_SIZE 256 /* 512B stack on GCC_ARM compiler cause out of memory on some 16kB RAM boards */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stack is quite small. Which devices were failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fails on nucleo_f070rb with GCC_ARM compiler on develop profile with 512B and 400B
384B stack is ok, so could be increased a bit to 320B or 350B

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack increased to 320B

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2017

Build : SUCCESS

Build number : 16
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 111
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

Triggering tests

/test mbed-os

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2017

Build : SUCCESS

Build number : 170
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

Skipping test trigger, missing label 'NEED CI'

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2017

Build : SUCCESS

Build number : 171
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5081/

Skipping test trigger, missing label 'NEED CI'

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2017

Test : SUCCESS

Build number : 76
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5081/76

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2017

Test : SUCCESS

Build number : 81
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5081/81

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2017

/morph uvisor-test

@adbridge adbridge merged commit 4d25bcc into ARMmbed:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maciejbocianski @theotherjimmy @0xc0170 @mbed-bot @mbed-ci @c1728p9 @adbridge